Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using this fork for some time in production, and necessary to say I took at least some effort to make sure it works as it should. For example, tests were migrated to PHPUnit, but we still run the original test suite to make sure it's even.
There's a slight breaking change for packages that depend both on the serializer and the compiler:
Hoa\Exception\Exception
-type exceptions are no longer thrown as the compiler does not depend on the exception abstractions it previously used. This is due to I tried to minimize the number of potentially abandoned dependencies, removing unnecessary for day to day operations.Second breaking change is in the fact that the compiler package no longer includes dev dependecies as non-dev. E.g. if one wants to use
getAST()
to make new Ln compilers on the fly, they'll need to include additional dependencies. The serializer is not affected.The above change also makes the serializer non-dependent on hoa/consistency, therefore hoaproject/Consistency#35 is no longer a problem when using the serializer.
Currently I'm the sole maintainer for the fork, but I'll be happy to accept a co-maintainer or two. (CI procedure isn't as robust as I'd want it, but that's not a big deal to fix. We'll fix it once we get there.)
Fixes #1182