Some suggestions~ #10
Comments
|
I haven't touched AnimColoir2 for a while. I have made a start a while back. But it still needs tons of work. I need to push myself to do this What do you mean by ON in the question about zcp? Perhaps an error in translation What is question 3 about, I don't really understand what you are asking |
Glad you replied~ |
Here's the current Chinese and English language files. Ive added English just in case, so you can compare. Im not sure how good your English is or perhaps you use a translate app. |
Of course~I'm happy to be of some help, if that's helpful. I use the version v2.2.1,I can only click the button I tried to use the effect of these two shortcuts, but the effect is not stable and happens differently when the playhead is in different positions?Maybe U can check it 2.The use of 3 frames is also relatively common in Japanese animation.The current version is also good enough, but I still hope you'll consider adding the 3 frame (●'◡'●) |
You can open those files in a simple text editor. Add the missing items or perhaps correct them
Im not sure what you mean. InBetweenNext or InBetweenPrev, moves the current frame between the next or previous 2 frames
Yes, this function sometimes doesn't seem to work. Im not sure why that is. When a frame is just 2, it seems it won't work. When its longer then 2 it does work. It also sometimes has issues when the frame you want to cut, is near the end of the timeline. It seems photoshop itself also has issues. When you want to split a frame which is 2 frames, that also doesn't work.
Im thinking of adding a function where user can set its own value, the default will be 3 but a user can add a different number. This will take much work, i need to add code ll over the place. Also, the icons, that's actually a custom font. It's kinda weird how this is set up in the beginning. |
|
I think I got add custom frame length working. I want to test back at home tomorrow, at work on osx I worked. I made it optional, so by default it will do 3 but the user can call a dialog and input any number. Then the next time you press it, it will use that number. Still need to work on the part that the playhead will also move. That's a tricky part as well. I'll hope I can push it to a test branch tomorrow |
Nice! It seems like a good choice,i'll complete CN trans on monday~ |
|
Okay had some issue again with custom frame step and later also with custom frame length. As far as i could test, it works also on Windows now. Could you test this branch, you need to install manually Ps this is the update language file |
Hi, this version does not show up for use(in Photosjop extension), I put the plugin in this directory: Ps this is the New update language file(Still lacking a few untranslated articles |
|
You need to remove everything behind "AnimDessign2", so remove "-custom-frame-length". Did you add that yourself? |
|
PS i changed the keyboard icon as well. Not sure it more clear, but its does look more like a keyboard. |
No, It came with me when I downloaded it"-custom-frame-length" PS.Before I dragged the whole folder directly into the extension folder like this,But it still doesn't show.. Later I put in this folder separately and put the licence in this folder,it shows... And I already added“DebugMode”=1,tryed 5-10 this morning,cant help.so i change it back to 1. |
|
No you need to look under "branches" then check, yesterday you showed it. It shoud show version 2.2.2 Per-user extension folder PS i know also why the folder name was wrong. When we use the zip from the webui, we need to open it and move only the com.sbaril.animdessin2 folder from the zip. Zie highlight in the screengrab below This is how the folder hierarchy should look like in the extensions folder. Your image, shows that you install the main folder from the zip. I noticed that com.sbaril.animdessin2 is now a sub folder. But since you can still get a plugin to work. That means its also installed in a different location Make sure you also download the test branch. But i think you already did that. THis is the correct branch; https://github.com/schroef/AnimDessin2/tree/custom-frame-length This how you switch branches in the webui |
|
I also found a small error in the manifest.xml file. At some point the extension didnt show for me neither. Should be fixed and it should show now |
Thanks for the reply~yep,i put folder in this path,it show up now. Here's new trans of CN.Some recommendations and questions remain. This effect and PS comes with the same effect of the new document, there is no need to specifically add this feature(maybe... I'm still waiting for your final version of these two effects~ I don't quite understand the effect of this feature，I hope you can explain it to me, or better yet, attach a GIF demo? |
|
Ive looked at some translations, some dont seem to correct when i translate them back. They describe something complete different. I think ive made a mistake somewhere with adding translations myself. Could perhaps compare it to the English version. But compare all lines if you are able to. Im sorry for that PS ive also found some more parts where i have not done all translation. For instance the "New Document Preset", this dialog has hard-coded translations. Could perhaps also do these?
Well i can add more frame length to the new document window. Im not going to make a new action. That new doc has no more shortcuts free i can use. Currently, you can set it to 1 and 2 frame length. I see if i can add 3,4,5
PS You can always make it with say 2 frames. Then select all layers and + to expand all the frame. See below what i did
This already works, like i said earlier. You can only make cuts if the existing layer or frame is long enough. At its core, it needs 3 frames of length, photoshop also wont cut a frame length of 2. I think minimal frame length required is 3. See below 2 examples of splitting it into 2 frames and splitting it into 3 frames. I guess you want the custom frame length here perhaps
If you want to move to the next frame but use custom frame step. This means instead of just jumping 1 frame, you can jump the number you set in the dialog. But it only works properly if all frames are the same length. This is because we also move to the selected layer or frame. So if we set it to 3 frames with 1 frame length it will jump to every 3rd frame. But we can also do this with frames which are 2 or 3. So in this next example i will still jump to every 3rd frame but the frames are 3 frames long This is handy because the user doesnt need to first set the play head and then select the frame. Photoshop default behavior is much more tedious. You need to first set the play head and then select the frame. Or you can select the frame and then use [UP] key to set the play head to that frame. But that only works if shortcuts are turned ON. No ive updated the scrubber yesterday as well. Prior i could only set the play head, but ive added the code from the custom frame step. So now it will also select the correct frame when we use the scrubber. Note again, this only works properly if all frames are the same length. When one or more frames have a different length, it will not select the proper frame. |
|
Thank you for your patience ~ I've basically finished updating the three files so you can check them out. I'll try the new feature effects in use, and I'll continue to give feedback in this post if I have any new questions~ |
|
Ive made some improvements. The scrubber now works also correctly in the external timeline panel. This was a bit hard since i need to talk between the 2 panels. It took me hours of research and testing, just to get something simple like this to work Ive also added current frame to the indicator Ill add those new translations as well |
OK~Looking forward to your beta version |
|
ive just uploaded the missing Chinese and French translations. Noticed one error, i didnt check all translations, but this one stood out. |
|
If all runs well, I'll merge this into the main branch |
OK,U can change it to:创建新的自定义时间轴/视频组 |
|
does everything work correctly and are translations okay. I'd like to merge it into main |
I think it's ok now,U can check it~ |
|
@Anxjoy I'm currently testing a new approach where the data is written to a folder in the ~/appdata/romaing/animdessin2/presets_json Need to check what happens on owx if try that folder |
yeah,i use Windows 11 now. |
|
Well it should work as normally. I just noticed this week, that my implemented "New Document + timeline" isnt able to save the presets properly on Windows. Notice in the video im able to load and save presets. The loading works currently, because it comes with a couple presets. But on Windows im not able to save files into the preset_json folder. On OSX this works just fine. I locally have a test version where i save to the userData folder and that seems to work. I was just wondering if the save presets from the new document dialog works on your side. I need to check if this adjusted method also works on OSX, but the computer at work is now broken. Waiting for a new system, so i cant test OSX for now. Also now when you create a new document it wont use the correct background and the framelenght is not correct. At least that was happening on my system on Windows. Save-Load-preset-New-Document-Dialog-v222.mp4 |
It looks like it can be created successfully, but a warning box pops up |
|
I wonder if you could add a feature like this onion skin in the future? The onion skin that comes with it is hard to use and not intuitive enough.. Here art 3 frames.when i open the onion skin,The first frame will be shown in purple, the third frame will be shown in green It will show the before and after frames in comparison by means of a customised transparency I think this feature could be a big job.... |
What does the dialog state? |
Sorry i can not do anything about that, that is internal code developed by Adobe Photoshop it self. PS why is the current not intuitive, because you alter it pretty well i think. Only feature not available is that what you state about different colors per frame. That "Feature" and "Past" color would be nice indeed Edit |
|
But are you able to save a preset from that new document dialog. It is at the bottom, i see you could use them. But saving doesnt seem to work properly. When you save a new version with a custom name, it should be selected automatically from that dropdown menu. So it should show in that menu. When i tried it here, it does not work. I dont seem to have write permissions in the extension folder. Thats why im trying a different approach, i still need to test this on OSX though |
|
Can is ask what panel you are showing in this image? This is not the default UI in Timeline panel in Photoshop |
yeah its here now, but still have the warning |
It's CSP Paint. Maybe U can see this link ?Or you can search for similar keywords，like"CSP timeline'"CSP Animation"... I think the animation feature of this software is much better or can provide you with some inspiration~ |
|
Yeah i found out it was Cartoon Studio Pro by translating the images and using google. Looks very interesting. I did some testing and got something raw working. There is one issue though. It keeps showing all the overlay colors ones move to previous or to next frame. Though the clean all button works fast, im not 100% sure about this. It does look handy! im no animator, but ive seen this same thing on an addon ive worked a bit on for Blender. It still needs more work, ive not made the settings dialog yet, i first wanted to see if it would work before in do work on that part. It also shows errors when im at the start and at the end. But i can get around those i guess. One thing I noticed, it does slow the stepping to next and previous frame a bit down. But that depends on how many frames you want in onionskin mode. It's still 100x faster than doing it manually. Currently it only works using next and previous edit. But after checking the videos you linked from CSP. I'll try to get it to work with the timeline scrubber I made. OnionSkin-Before-After-Color.mp4 |
I need to take a look at the version which is in the master branch then. I guess there most be some error in the code in that version |
Basically.~ You're too good at executing. |
|
The issue is, that onionskin panel from photoshop and the data is not reachable by extendscript. I cant make a custom panel for that. There still needs to be 2 dialogs, one is Photoshop onionskin baked in settings and than the extra settings will be a different panel. I can not get around this. There are parts of Photoshop which are simply not exposed for script. When I kept the before and after onionskin frame to just 1 frame. It was still pretty fast, almost the same as using the next and previous edit button |
|
I made a new branch for this so you can test it. It is still hard-coded so it only works 1 frame before and 1 after and you cant adjust the colors. So it shows blue and red for before and after. I'll make a dialog for this later. This version also have the fix for the new document dialog i was working on. I still dont know if this works on OSX |
Ok~I'll go test it. As for changing colours this is not urgent yet, it's mainly a matter of setting up the new onion skin panel |
new document is working,but still pop-up warning box. |
|
Are you in the new branch. I think your still downloading from the main branch. You need to switch branches at the top. There is a dropdown menu. I showed you earlier. Don't download the zip from the right neither. See how you switch branches, Change-branches-github.mp4ive also made this version 2.2.3 So in the context menu > About AnimDessin2. You should see this, if you see a different number you still have a old version installed some where. What version of Photoshop are you working with? |
I use PScc 24.4.1 |
|
Could you explain what you mean by "it's harder to follow"? Does this v2.2.3 still cause that dialog error when creating new document? Does the onionskin before and after function work? |
|
Can you translate that error dialog for me. If i let Google Translate do it. It says something like this "Use Adobe Photoshop only for Photoshop..." the last line does not get translated
|
Error:A regular Photoshop error has occurred, this feature may not work in this version of |
the onionskin before and after function work，Sometimes it responds, sometimes it doesn't. |
Well it works as ive shown on earlier videos. You use either the global timeline scrubber but clicking somewhere or the next and previous edit button. It does not work in Photoshop native toolbar, i have no access to that and use that with the custom script See below how to use it and how to show global timeline scrubber Onionskin-BeforeAfter-usage-scrubber-nextpreveditbtn.mp4 |
Ill try to update and see if i get the same error EDIT new-document-ps-251.mp4 |
When I create a new video preset a warning box pops up immediately，like this: but it still could work~not a big problem |
That's what I'm trying to say: https://github.com/schroef/AnimDessin2/assets/149565023/9813f1d3-3add-439b-b539-21923620b6cf |
|
Well it looks like it is working after all. The issue is, you did not set the play head to the correct frame. Dont use the photoshop timeline playhead, i can not do anything when you move that one. Only move the global timeline scrubber which comes with the panel. And those 2 buttons next and previous. See what ive marked, RED i can not influence using that, green, than it works with onionskin before and after. Best thing to do, is enable shortcuts in the photoshop timeline panel. I think that is causing the error maybe now I thing about it. (edit doesnt matter actually) When the selected frame and the playhead are in the same spot. Then the scrubber and the next and previous edit will work as intended. The whole issue in Photoshop is, that the user normally needs to set both manually at the same position before you van draw. With the edits I made, if they are set correct at the same spot. All the functions will make them move synchronized. So it will move both the timeline indicator and also move the selected frame. Somehow when you create a document it's either shortcut issue or it won't move back to the beginning of the timeline. That is causing the issue Edit |
OK,I'll keep testing this version.~ |
|
When using the interface and moving from frame to frame, its best to use AnimDessin2 toolbar. Only then will the before and after onion color work. Same as the other functions like moving around and keeping the selected frame and timeline at the same place. This only works when using AnimDessin2 toolbar. Photoshop own timeline wont let you do that and you need to move playhead indicator and after that select the frame. Much more tedious workflow |
|
I'll also will add that extra dialog window so we can activate it, change before- & after-color |
Hello,love your work,but there are still some issues that need improvement（maybe
The text was updated successfully, but these errors were encountered: