-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Install pandoc manually from GitHub release binaries #2307
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2307 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 69 69
Lines 4535 4535
Branches 802 802
=======================================
Hits 4458 4458
Misses 45 45
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b430e70
to
1c60261
Compare
# Ubuntu 22.04's pandoc is too old (2.9.2.x), so install manually | ||
# until the ubuntu-latest updates. | ||
curl --silent --location --remote-name https://github.com/jgm/pandoc/releases/download/3.1.6.2/pandoc-3.1.6.2-1-amd64.deb | ||
sudo apt-get install ./pandoc-*amd64.deb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The runtime warning doesn't kill the build, so while this isn't stricly necessary the Ubuntu version of pandoc
is very old, and so maybe it is better to use something outside the package manager but more to date.
* Ubuntu 22.04 (current operating system for GitHub Actions runners for 'ubuntu-latest') will install pandoc v2.9.2.1 through apt-get which is too old for modern versions of nbsphinx. Installing directly from binaries provided on GitHub allows a workaround for getting newer versions of pandoc on runners until the GitHub Actions runner environment updates. - Avoids ``` RuntimeWarning: You are using an unsupported version of pandoc (2.9.2.1). Your version must be at least (2.14.2) but less than (4.0.0). ``` from nbsphinx.
1c60261
to
595f493
Compare
Description
from nbsphinx.
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: