From c4cb25dca2dc27202e2884cda2f7f6c381bf8580 Mon Sep 17 00:00:00 2001 From: Matthew Feickert Date: Wed, 6 Sep 2023 16:26:04 -0500 Subject: [PATCH 1/2] docs: Add v0.7.4 release notes * Add release notes for pyhf v0.7.4. --- docs/release-notes.rst | 1 + docs/release-notes/v0.7.4.rst | 28 ++++++++++++++++++++++++++++ 2 files changed, 29 insertions(+) create mode 100644 docs/release-notes/v0.7.4.rst diff --git a/docs/release-notes.rst b/docs/release-notes.rst index ec607b5b70..c11d6c2019 100644 --- a/docs/release-notes.rst +++ b/docs/release-notes.rst @@ -2,6 +2,7 @@ Release Notes ============= +.. include:: release-notes/v0.7.4.rst .. include:: release-notes/v0.7.3.rst .. include:: release-notes/v0.7.2.rst .. include:: release-notes/v0.7.1.rst diff --git a/docs/release-notes/v0.7.4.rst b/docs/release-notes/v0.7.4.rst new file mode 100644 index 0000000000..229d96ca11 --- /dev/null +++ b/docs/release-notes/v0.7.4.rst @@ -0,0 +1,28 @@ +|release v0.7.4|_ +================= + +This is a patch release from ``v0.7.3`` → ``v0.7.4``. + +Fixes +----- + +* Skip callbacks with dead weakrefs while iterating over callbacks in ``pyhf`` + events, like :func:`pyhf.set_backend`, to avoid the possibility of accessing + dead weakrefs before they could be garbage collected. + (PR :pr:`2310`) + + The fixed bug was subtle and occurred nondeterministically when the + :class:`pyhf.tensorlib` was changed repeatedly causing dead weakrefs + to be accessed before Python's garbage collection could remove them. + Most users should be unaffected by this. + +Contributors +------------ + +``v0.7.4`` benefited from contributions from: + +* Daniel Werner +* Jonas Rembser + +.. |release v0.7.4| replace:: ``v0.7.4`` +.. _`release v0.7.4`: https://github.com/scikit-hep/pyhf/releases/tag/v0.7.4 From cb2d3b33e88962c1dbda12b27ca690a0e8da996b Mon Sep 17 00:00:00 2001 From: Matthew Feickert Date: Wed, 6 Sep 2023 16:48:42 -0500 Subject: [PATCH 2/2] revise --- docs/release-notes/v0.7.4.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/release-notes/v0.7.4.rst b/docs/release-notes/v0.7.4.rst index 229d96ca11..e357f5523b 100644 --- a/docs/release-notes/v0.7.4.rst +++ b/docs/release-notes/v0.7.4.rst @@ -14,7 +14,7 @@ Fixes The fixed bug was subtle and occurred nondeterministically when the :class:`pyhf.tensorlib` was changed repeatedly causing dead weakrefs to be accessed before Python's garbage collection could remove them. - Most users should be unaffected by this. + Most users should be unaffected. Contributors ------------