Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add poi_name to Model construction in notebooks #2336

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Sep 20, 2023

Description

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Ensure all pyhf.Model calls in the example notebooks that don't
  already have a poi_name definied have `poi_name="mu"` set.
* Amends PR https://github.com/scikit-hep/pyhf/pull/2328

* Ensure all pyhf.Model calls in the example notebooks that don't
  already have a poi_name definied have `poi_name="mu"` set.
* Amends PR https://github.com/scikit-hep/pyhf/pull/ 2328
@matthewfeickert matthewfeickert added the docs Documentation related label Sep 20, 2023
@matthewfeickert matthewfeickert self-assigned this Sep 20, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@matthewfeickert matthewfeickert added the fix A bug fix label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4ec7bf3) 98.28% compared to head (81f2756) 98.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2336   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files          69       69           
  Lines        4538     4538           
  Branches      803      803           
=======================================
  Hits         4460     4460           
  Misses         45       45           
  Partials       33       33           
Flag Coverage Δ
contrib 97.86% <ø> (ø)
doctest 60.99% <ø> (ø)
unittests-3.10 96.29% <ø> (ø)
unittests-3.11 96.29% <ø> (ø)
unittests-3.8 96.31% <ø> (ø)
unittests-3.9 96.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert
Copy link
Member Author

The build failure was addressed in PR #2337, so this is fine to merge.

@matthewfeickert matthewfeickert merged commit c096b33 into main Sep 20, 2023
19 of 20 checks passed
@matthewfeickert matthewfeickert deleted the fix/apply-poi-to-models-in-notebooks branch September 20, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related fix A bug fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant