From 81f2756dd53dbaeacbffcb06cc5d42e6813cc861 Mon Sep 17 00:00:00 2001 From: Matthew Feickert Date: Wed, 20 Sep 2023 09:52:11 -0500 Subject: [PATCH] fix: Add poi_name to Model construction in notebooks * Ensure all pyhf.Model calls in the example notebooks that don't already have a poi_name definied have `poi_name="mu"` set. * Amends PR https://github.com/scikit-hep/pyhf/pull/ 2328 --- docs/examples/notebooks/ShapeFactor.ipynb | 2 +- docs/examples/notebooks/StatError.ipynb | 2 +- docs/examples/notebooks/histogrammar.ipynb | 2 +- docs/examples/notebooks/histosys.ipynb | 2 +- docs/examples/notebooks/multichannel-coupled-histo.ipynb | 2 +- docs/examples/notebooks/multichannel-coupled-normsys.ipynb | 2 +- docs/examples/notebooks/normsys.ipynb | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/examples/notebooks/ShapeFactor.ipynb b/docs/examples/notebooks/ShapeFactor.ipynb index 32274c94ab..db5bf3ac55 100644 --- a/docs/examples/notebooks/ShapeFactor.ipynb +++ b/docs/examples/notebooks/ShapeFactor.ipynb @@ -74,7 +74,7 @@ " },\n", " ]\n", " }\n", - " pdf = pyhf.Model(spec)\n", + " pdf = pyhf.Model(spec, poi_name=\"mu\")\n", " data = []\n", " for channel in pdf.config.channels:\n", " data += sourcedata[channel]['bindata']['data']\n", diff --git a/docs/examples/notebooks/StatError.ipynb b/docs/examples/notebooks/StatError.ipynb index 950b3d914d..7cfad53f57 100644 --- a/docs/examples/notebooks/StatError.ipynb +++ b/docs/examples/notebooks/StatError.ipynb @@ -72,7 +72,7 @@ " # }\n", " ]\n", "}\n", - "p = pyhf.Model(spec)" + "p = pyhf.Model(spec, poi_name=\"mu\")" ] }, { diff --git a/docs/examples/notebooks/histogrammar.ipynb b/docs/examples/notebooks/histogrammar.ipynb index 326c737c24..fb723ff786 100644 --- a/docs/examples/notebooks/histogrammar.ipynb +++ b/docs/examples/notebooks/histogrammar.ipynb @@ -156,7 +156,7 @@ "metadata": {}, "outputs": [], "source": [ - "p = pyhf.Model(spec)\n", + "p = pyhf.Model(spec, poi_name=\"mu\")\n", "\n", "data = data_histogram.toJson()['data']['values'] + p.config.auxdata" ] diff --git a/docs/examples/notebooks/histosys.ipynb b/docs/examples/notebooks/histosys.ipynb index e8518018a5..83192fc2e2 100644 --- a/docs/examples/notebooks/histosys.ipynb +++ b/docs/examples/notebooks/histosys.ipynb @@ -56,7 +56,7 @@ " },\n", " }\n", " }\n", - " pdf = Model(spec)\n", + " pdf = Model(spec, poi_name=\"mu\")\n", " data = source['bindata']['data'] + pdf.config.auxdata\n", " return data, pdf" ] diff --git a/docs/examples/notebooks/multichannel-coupled-histo.ipynb b/docs/examples/notebooks/multichannel-coupled-histo.ipynb index 3c565fd93f..e703ff41af 100644 --- a/docs/examples/notebooks/multichannel-coupled-histo.ipynb +++ b/docs/examples/notebooks/multichannel-coupled-histo.ipynb @@ -108,7 +108,7 @@ " },\n", " ]\n", " }\n", - " pdf = Model(spec)\n", + " pdf = Model(spec, poi_name=\"mu\")\n", " data = []\n", " for channel in pdf.config.channels:\n", " data += sourcedata[channel][\"bindata\"][\"data\"]\n", diff --git a/docs/examples/notebooks/multichannel-coupled-normsys.ipynb b/docs/examples/notebooks/multichannel-coupled-normsys.ipynb index 8d9b304a7e..7ffbd69a85 100644 --- a/docs/examples/notebooks/multichannel-coupled-normsys.ipynb +++ b/docs/examples/notebooks/multichannel-coupled-normsys.ipynb @@ -78,7 +78,7 @@ " }\n", " },\n", " }\n", - " pdf = Model(spec)\n", + " pdf = Model(spec, poi_name=\"mu\")\n", " data = []\n", " for c in pdf.config.channel_order:\n", " data += sourcedata[c]['bindata']['data']\n", diff --git a/docs/examples/notebooks/normsys.ipynb b/docs/examples/notebooks/normsys.ipynb index 0488600e92..056eeaa808 100644 --- a/docs/examples/notebooks/normsys.ipynb +++ b/docs/examples/notebooks/normsys.ipynb @@ -53,7 +53,7 @@ " },\n", " }\n", " }\n", - " pdf = Model(spec)\n", + " pdf = Model(spec, poi_name=\"mu\")\n", " data = observed_counts + pdf.config.auxdata\n", " return data, pdf" ]