Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow support for multi-label algorithms #174

Open
wdevazelhes opened this issue Feb 26, 2019 · 7 comments
Open

Allow support for multi-label algorithms #174

wdevazelhes opened this issue Feb 26, 2019 · 7 comments

Comments

@wdevazelhes
Copy link
Member

wdevazelhes commented Feb 26, 2019

Multi-labels problems with a lot of labels are a good use case of metric learning, so we could add support for it in the algorithms. In supervised ones it would mean modifying the loss function a bit (we have been discussing it with @bellet for NCA's PR in scikit-learn for instance)
For weakly supervised ones it would mean make tuples from multi-labeled data (it seems that there are several strategies to do so, like how much labels do points share, etc...)

@terrytangyuan
Copy link
Member

Could you share the link to NCA PR in scikit-learn? Are you reusing what’s available in metric-learn?

@wdevazelhes
Copy link
Member Author

Could you share the link to NCA PR in scikit-learn?

Sure, here is the link: scikit-learn/scikit-learn#10058

Are you reusing what’s available in metric-learn?

In fact I reused a lot of a PR about LMNN (scikit-learn/scikit-learn#8602) for the architecture of the code, and just replaced the function with NCA's loss function. This PR is quite developed with respect to the error messages, the checks of the parameters, the automatic initialization, etc, so I guess we could get some of the developments from this PR in metric-learn (that's already what we did in some PRs like #113, #105, and #99)

@wdevazelhes wdevazelhes added this to the v0.6.0 milestone Mar 5, 2019
@wdevazelhes
Copy link
Member Author

Btw the PR has been merged in scikit-learn recently ! 🎉

@terrytangyuan
Copy link
Member

Nice job! Congrats!

@wdevazelhes
Copy link
Member Author

Thanks !

@bellet
Copy link
Member

bellet commented Mar 13, 2019

Also to mention that it was @GaelVaroquaux who originally suggested to investigate the multi-label setting ;-)

@bellet bellet removed this from the v0.6.0 milestone Apr 19, 2019
@angelotc
Copy link

Looking forward to this development if it is still a thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants