Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMX integration test failing: Shape of pixel offsets does not correspond to detector_number #49

Open
nvaytet opened this issue Jan 13, 2025 · 4 comments · May be fixed by #50
Open

NMX integration test failing: Shape of pixel offsets does not correspond to detector_number #49

nvaytet opened this issue Jan 13, 2025 · 4 comments · May be fixed by #50
Assignees

Comments

@nvaytet
Copy link
Member

nvaytet commented Jan 13, 2025

See https://git.esss.dk/dmsc-nightly/dmsc-nightly/-/jobs/52344

@MridulS
Copy link
Member

MridulS commented Jan 14, 2025

This started failing with chexus==24.12.0 as it had #39

@SimonHeybrock
Copy link
Member

If I remember correctly the conclusion on Slack was that this is allowed if the file uses the axis attribute for the offsets. I think ScippNexus already supports this, so we may just need to fix Chexus.

@jokasimr
Copy link
Contributor

Did I understand correctly that the conclusion was that if x{yz}_pixel_offset has an axis attribute then it is fine that the shape is different from detector_number and chexus should not return a violation?

I'm asking because the file that failed the test /ess/data/coda/2025/994160/raw/994160_00040831.hdf does not have an axis attribute on the /entry/instrument/detector_panel_0/x_pixel_offset dataset, so the test will still fail if we fix this in chexus.

@SimonHeybrock
Copy link
Member

Did I understand correctly that the conclusion was that if x{yz}_pixel_offset has an axis attribute then it is fine that the shape is different from detector_number and chexus should not return a violation?

Correct!

@jokasimr jokasimr linked a pull request Jan 20, 2025 that will close this issue
@jokasimr jokasimr self-assigned this Jan 20, 2025
@jokasimr jokasimr moved this from Selected to In progress in Development Board Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

4 participants