Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can AkkaConsumber inherit from a common base trait? #48

Open
coreyauger opened this issue Apr 20, 2016 · 2 comments
Open

Can AkkaConsumber inherit from a common base trait? #48

coreyauger opened this issue Apr 20, 2016 · 2 comments

Comments

@coreyauger
Copy link
Contributor

I would like to have a common base for akka consumers... to allow for a generic way to process clean-up

ex:
private[this] val consumerRegistry = new ConcurrentHashMap[String, AkkaConsumerBase[String, _]]
`

def shutdown() = {
    logger.info("Shutting down Event Bus")
    producer.close()
    Await.ready(Future.sequence(consumerRegistry.map(e => e._2.stop())), 5 minute)
  }

Thoughts ?

@sclasen
Copy link
Owner

sclasen commented Apr 20, 2016

seems legit, want to do a PR?

@coreyauger
Copy link
Contributor Author

Sounds good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants