Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong network interface name if the name is long #1089

Open
3 tasks done
hellodword opened this issue Jan 7, 2024 · 2 comments · May be fixed by #1090
Open
3 tasks done

Wrong network interface name if the name is long #1089

hellodword opened this issue Jan 7, 2024 · 2 comments · May be fixed by #1090

Comments

@hellodword
Copy link

hellodword commented Jan 7, 2024 •
edited
Loading

Describe the bug

network interface name get truncated with ifconfig

To reproduce

$ ip link show up
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1000
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT group default qlen 1000
3: nameislong: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc fq_codel state DOWN mode DEFAULT group default qlen 1000

$ ifconfig 
lo        Link encap:Local Loopback
eth0      Link encap:Ethernet
nameislongLink encap:(hwtype unknown)

bash-completion/bash_completion

Lines 1723 to 1738 in 2b7fc19

_comp_compgen_available_interfaces()
{
local PATH=$PATH:/sbin
local generated
_comp_compgen -v generated split -- "$({
if [[ ${1-} == -w ]]; then
iwconfig
elif [[ ${1-} == -a ]]; then
ifconfig || ip -c=never link show up || ip link show up
else
ifconfig -a || ip -c=never link show || ip link show
fi
} 2>/dev/null | _comp_awk \
'/^[^ \t]/ { if ($1 ~ /^[0-9]+:/) { print $2 } else { print $1 } }')" &&
_comp_compgen -U generated set "${generated[@]}"
}

Then the _comp_compgen_available_interfaces -a will return nameislongLink instead of nameislong

Reproduce:

sudo tunctl -t nameislong
sudo ip addr add 10.23.45.0/24 dev nameislong
sudo ip link set dev  nameislong up

# TAB
curl --interface nameis

Expected behavior

Versions (please complete the following information)

  • Operating system name/distribution and version: NixOS 24.05.20240102.bd645e8
  • bash version, echo "$BASH_VERSION": 5.2.21(1)-release
  • bash-completion version, (IFS=.; echo "${BASH_COMPLETION_VERSINFO[*]}"): 2.11

Additional context

It's bug of upstream inetutils, but maybe we can simply use iproute2 as default choose

ip -c=never link show up || ip link show up || ifconfig

bash-completion/bash_completion

Lines 1731 to 1733 in 2b7fc19

ifconfig || ip -c=never link show up || ip link show up
else
ifconfig -a || ip -c=never link show || ip link show

@hellodword hellodword linked a pull request Jan 8, 2024 that will close this issue
Open
hellodword added a commit to hellodword/bash-completion that referenced this issue Feb 5, 2024
@hellodword
chore: prefer using iproute2 instead of ifconfig
e8a84d5 
long interface name will be truncated by ifconfig (issue scop#1089), prefer to use iproute2
hellodword added a commit to hellodword/bash-completion that referenced this issue Feb 5, 2024
@hellodword
chore: prefer using iproute2 instead of ifconfig
80b3632 
long interface name will be truncated by ifconfig (issue scop#1089), prefer to use iproute2
hellodword added a commit to hellodword/bash-completion that referenced this issue Feb 8, 2024
@hellodword
fix: use iproute2 to get full interface name
5edb1f3 
long interface name may be truncated by ifconfig, prefer iproute2.
See also: scop#1089
hellodword added a commit to hellodword/bash-completion that referenced this issue Feb 8, 2024
@hellodword
fix: use iproute2 to get full interface name
7dc7f7e 
long interface name may be truncated by ifconfig, prefer iproute2.
See also: scop#1089
hellodword added a commit to hellodword/bash-completion that referenced this issue Feb 8, 2024
@hellodword
fix: use iproute2 to get full interface name
fd9d424 
long interface name may be truncated by ifconfig, prefer iproute2.
See also: scop#1089
hellodword added a commit to hellodword/bash-completion that referenced this issue Feb 8, 2024
@hellodword
fix: use iproute2 to get full interface name
fb9c1d7 
long interface name may be truncated by ifconfig, prefer iproute2.
See also: scop#1089
hellodword added a commit to hellodword/bash-completion that referenced this issue Feb 8, 2024
@hellodword
fix: use iproute2 to get full interface name
2c94bf1 
long interface name may be truncated by ifconfig, prefer iproute2.
See also: scop#1089
@yedayak
Copy link
Collaborator

yedayak commented Aug 26, 2024

BTW, which packages provide ip and ifconfig on your system? I get different outputs on my system, the outputs span multiple lines

@hellodword
Copy link
Author

BTW, which packages provide ip and ifconfig on your system? I get different outputs on my system, the outputs span multiple lines

For me it's inetutils-2.5, here is a minimal reproduce:

{
  inputs = {
    nixpkgs.url = "github:NixOS/nixpkgs/d0e1602ddde669d5beb01aec49d71a51937ed7be";
  };

  outputs = { self, nixpkgs, ... }:
    let
      supportedSystems = [ "x86_64-linux" ];
      forEachSupportedSystem = f: nixpkgs.lib.genAttrs supportedSystems (system: f {
        pkgs = import nixpkgs { inherit system; };
      });
    in
    {
      devShells = forEachSupportedSystem ({ pkgs }: rec {
        default = pkgs.mkShell {
          packages = with pkgs; [
            inetutils
            tunctl
          ];
        };
      });
    };
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prefer using iproute2 instead of ifconfig hellodword/bash-completion
2 participants
@yedayak @hellodword