Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): enable .java filename completion for java command #1197

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

jiri-pejchal
Copy link
Contributor

@jiri-pejchal jiri-pejchal commented May 20, 2024

Modify java command completion scripts to also complete filenames with the .java extension. This adds support for

  • JEP 330: Launch Single-File Source-Code Programs
  • JEP 458: Launch Multi-File Source-Code Programs

edited by @akinomyoga

Fixes #1196

@jiri-pejchal
Copy link
Contributor Author

This pull request incorporates changes according to the commentary from #662 .

completions/java Outdated Show resolved Hide resolved
@akinomyoga
Copy link
Collaborator

The essential fix seems to be the same as #662 (comment). I prefer to leave the credit to the original author of #662, e.g., by including the Co-authored-by: ... in the commit message.

Modify java command completion scripts to also complete filenames
with the .java extension. This adds support for
- JEP 330: Launch Single-File Source-Code Programs
- JEP 458: Launch Multi-File Source-Code Programs

Closes scop#1196

Co-authored-by: frankslin <[email protected]>
@jiri-pejchal
Copy link
Contributor Author

  • fixed tests when can_list_jar is False
  • @frankslin added to Co-authored-by

Copy link
Owner

@scop scop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@scop scop merged commit 959ce82 into scop:main Jun 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable .java Filename Completion for java Command
3 participants