Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'/connect/*/callback' URLs aren't visited after authorize #25

Open
csehydrogen opened this issue Jul 14, 2015 · 2 comments
Open

'/connect/*/callback' URLs aren't visited after authorize #25

csehydrogen opened this issue Jul 14, 2015 · 2 comments

Comments

@csehydrogen
Copy link

/connect/* URLs are using passport.authorize('*'), whose callback URLs are set to http://localhost:8080/auth/*/callback.
My temporary fix is making another set of passport.authorize('*-connect'), whose callback URLs are set to http://localhost:8080/connect/*/callback.

@hagen
Copy link

hagen commented Aug 28, 2015

I've found the same @csehydrogen. There's some black magic in there. Similarly, Twitter doesn't allow multiple callback URLs (but does allow overwriting of the callback, so...). Did you find a neater way to get /connect/ callbacks working?

@csehydrogen
Copy link
Author

@hagen No, I didn't. 😢 Those duplicated codes still tickle me.
I think that this should be fixed in passport or SNS APIs, not in this repository. (by supporting different callbacks for authentication & authorization, etc.)
But, at least, repository users should be informed about this issue, because it is tutorial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants