Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just a little fix on the login spinner in chapter 17 #38

Open
rmnblm opened this issue Feb 5, 2016 · 1 comment
Open

Just a little fix on the login spinner in chapter 17 #38

rmnblm opened this issue Feb 5, 2016 · 1 comment

Comments

@rmnblm
Copy link

rmnblm commented Feb 5, 2016

I was reading the book and studied the code and found a little mistake.
Not going to make a pull request because of this.

https://github.com/scotch-io/mean-machine-code/blob/master/17-user-crm/public/app/views/pages/login.html#L31

Just replace
<span ng-if="login.processing" class="spinner"><span class="glyphicon glyphicon-repeat"></span></span>

with
<span ng-if="login.processing"><span class="glyphicon glyphicon-repeat spinner"></span></span>

By the way: Thanks for this awesome book!

@sychen41
Copy link

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants