Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't get pgoapi via pip without installing git #4

Open
Azryyal opened this issue Aug 7, 2016 · 6 comments
Open

Can't get pgoapi via pip without installing git #4

Azryyal opened this issue Aug 7, 2016 · 6 comments

Comments

@Azryyal
Copy link

Azryyal commented Aug 7, 2016

pip install -r requirement.txt

Got this at the end of the install:

Obtaining pgoapi from git+git://github.com/keyphact/pgoapi.git@fd462be412ac347ab517b68f269e2342a7226909#egg=pgoapi (from -r requirements.txt (line 18))
Cloning git://github.com/keyphact/pgoapi.git (to fd462be412ac347ab517b68f269e2342a7226909) to c:\pokemongo-map-develop\src\pgoapi
Error [Error 2] The system cannot find the file specified while executing command git clone -q git://github.com/keyphact/pgoapi.git C:\PokemonGo-Map-develop\src\pgoapi
Cannot find command 'git'

I don't have git installed on my laptop. If that is a requirement, then that should be noted someplace. If that shouldn't be a requirement, then the requirement.txt file shouldn't be requesting a clone.

@Azryyal Azryyal changed the title Can't get pgoapi via pip Can't get pgoapi via pip without installing git Aug 7, 2016
@skvvv
Copy link

skvvv commented Aug 7, 2016

You need to install "git" to be able to clone.
Requirement text is only for python based modules.
git command is something different, not related to python in any way.

@Azryyal
Copy link
Author

Azryyal commented Aug 7, 2016

Yeah, I got that. But there should be something, perhaps in the Wiki or README that says this requires git installed. I had no problem figuring out that I needed to install git, but I would have done so first if there was something that told me to do so.

@imynwulf
Copy link

imynwulf commented Aug 7, 2016

@Azryyal So.... You're on git hub and don't expect to have to use git? I'd say that's sort of understood.

@Azryyal
Copy link
Author

Azryyal commented Aug 7, 2016

Why? I didn't need it to download AHAAA's version and use it.

@imynwulf
Copy link

imynwulf commented Aug 7, 2016

AHAAA used to include an older copy of the pgoapi. At some point, the develop branch was changed to download a new version as part of the pip install.

Either you had an old version, or you were on the master branch.

@Azryyal
Copy link
Author

Azryyal commented Aug 7, 2016

Right. I wasn't interested in developing. I just wanted to use, so I was on the 2.1.0 branch (release).

Ok. I've updated README.md and created pull request #10 . Once that is pulled in, this can be closed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants