From 2dd5d4cd04f8bcb9bbfcc03c37c2cdee847e55e6 Mon Sep 17 00:00:00 2001
From: Carl Montanari <carl.r.montanari@gmail.com>
Date: Fri, 9 Aug 2024 15:47:18 -0700
Subject: [PATCH] chore: remove pylama/pydocstyle, just use pylint

---
 .pylintrc            | 5 +++--
 Makefile             | 2 +-
 noxfile.py           | 6 +++---
 pyproject.toml       | 2 +-
 requirements-dev.txt | 2 --
 5 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/.pylintrc b/.pylintrc
index ea3c6c8..fb748a9 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -143,7 +143,7 @@ confidence=HIGH,
 # --enable=similarities". If you want to run only the classes checker, but have
 # no Warning level messages displayed, use "--disable=all --enable=classes
 # --disable=W".
-disable=C0103,C0115,R0901,R0902,R0903,R0913,R0914,W1202,W1203
+disable=C0103,C0115,R0401,R0801,R0901,R0902,R0903,R0913,R0914,W1202,W1203
 # C0103 = constant-name (a little too aggressive for some things that aren't "really" constants")
 # C0115 = class docstrings (init doc strings cover this already)
 # W1202 = use % formatting for logging (ignore, using f-strings)
@@ -153,7 +153,8 @@ disable=C0103,C0115,R0901,R0902,R0903,R0913,R0914,W1202,W1203
 # R0903 = too-few-public methods
 # R0913 = too-many-arguments
 # R0914 = too-many-local-variables
-
+# R0801 = similar-lines
+# R0401 = cyclic-import (too many false positives, seems like this is a common complaint :p)
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option
 # multiple time (only on the command line, not in the configuration file where
diff --git a/Makefile b/Makefile
index c0fb2a9..372dce4 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
 lint:
 	python -m isort .
 	python -m black .
-	python -m pylama .
+	python -m pylint nornir_scrapli/
 	python -m pydocstyle .
 	python -m mypy --strict nornir_scrapli/
 
diff --git a/noxfile.py b/noxfile.py
index eaf7909..729aef6 100644
--- a/noxfile.py
+++ b/noxfile.py
@@ -151,9 +151,9 @@ def black(session):
 
 
 @nox.session(python=["3.11"])
-def pylama(session):
+def pylint(session):
     """
-    Nox run pylama
+    Nox run pylint
 
     Args:
         session: nox session
@@ -166,7 +166,7 @@ def pylama(session):
 
     """
     session.install(*_get_install_test_args())
-    session.run("python", "-m", "pylama", ".")
+    session.run("python", "-m", "pylint", "nornir_scrapli/")
 
 
 @nox.session(python=["3.11"])
diff --git a/pyproject.toml b/pyproject.toml
index 700bdaa..0c6bf9c 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -85,7 +85,7 @@ target-version = [
 
 [tool.pylama]
 linters = "mccabe,pycodestyle,pylint"
-skip = ".nox/*,.private/*,build/*,docs/*,private/*,site/*,tests/*,venv/*"
+skip = ".nox/*,build/*,tests/*,venv/*"
 
 [tool.pylama.pycodestyle]
 max_line_length = 100
diff --git a/requirements-dev.txt b/requirements-dev.txt
index c839ca7..a8734dd 100644
--- a/requirements-dev.txt
+++ b/requirements-dev.txt
@@ -3,9 +3,7 @@ darglint>=1.8.1,<2.0.0
 isort>=5.10.1,<6.0.0
 mypy>1.0.0,<2.0.0
 nox==2024.4.15
-pycodestyle>=2.8.0,<3.0.0
 pydocstyle>=6.1.1,<7.0.0
-pylama>=8.4.0,<9.0.0
 pylint>=3.0.0,<4.0.0
 pytest-cov>=3.0.0,<5.0.0
 pytest>=7.0.0,<8.0.0