Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
routes.json
toroutes.js
and move conditional logic into that shared file so that all scripts that process routes can be on the same page (heh) about what routes exist. For example,webpack
andconfigure-fastly.js
will now always see the same routes given the same environment variables.fastly-extended.js
with correct JSDoc type hintsnode_modules/fastly/lib/index.js
are malformed. Newer versions are correct, but present a VERY different API.configure-fastly.js
and friendsasync
library expectsError
objects, not stringserr, res
style arguments to a function that only takeserr
These changes should make it easier to understand our routing and Fastly configuration, but should not cause any significant difference in the actual configuration.
This is the foundation for an upcoming functional change to
configure-fastly.js
Test Coverage:
I ran this locally and the output seems reasonable, but I'd need to compare it to the real Fastly configuration to be sure. On the plus side, this will provide a baseline so it's easier to tell in the future if a change has affected the
configure-fastly.js
output. Existing tests pass.