On story page top message line shows Twitter handle instead of full name

[scotthansonde]

On the editor page the top message line shows "by" my full name (personName from the pagetable), then my Twitter handle.

On the story page the top message line shows "by" my Twitter handle (twitterscreenname), then my Twitter handle again.

I like my full name better :-)

[scripting]

Can I get an example of a page that exhibits the behavior?

[scotthansonde]

I noticed it at my own site http://1999.papascott.de/2016/05/31/0010.html

But I suspect it happens on all sites running 1999.io

[scripting]

I wanted to see what the value of personName was on your site.

On mine it's davewiner, on yours it's Scott Hanson.

I will look at this in the next session. I want to get this right too.

[scotthansonde]

I see something has changed! :-)

When I view my page when logged in to Twitter, the Twitter handle shows briefly, then I see my full name.

When I log out of Twitter and reload, it reverts to my Twitter handle.

I log back into to Twitter, the name flickers back and forth a couple times and ends up at my full name.

[scripting]

Honestly that code is something of a mess because I tried to optimize a while back, and while it did get faster, that's when a lot of the "jiggles" were introduced.

I have to go do thorough debug of that code, and re-simplify it, so that all the problems in there can easily be fixed.

What you saw last night was the result of me making a one-line change to see how you would react.

Because you and I are seeing different things because of the messiness of this code.

Thanks for sticking with it Scott. I am not closing this issue at this time. Plan to take a look at it right now, and come up with some kind of plan. ;-)

[scripting]

I made two changes.

1. When it renders the page, it puts personName in the link to the Twitter handle instead of the twitter username.
2. Fixed a problem where if you weren't logged in it wouldn't use the personName value which it has handy even though it thought it didn't have it.

Old un-reviewed code is the culprit. Now has been more reviewed. Not fully reviewed yet.

[scotthansonde]

OK, I see the changes and the flickers are mostly gone.

There is a barely noticeable flicker when the text within the div divtopmsgline is dynamically changed, but I only notice it because I know it's happening. A normal person loading the page wouldn't notice it. :-)

[scripting]

I could probably get rid of those too.

The good thing about it is they are always in my face, every time I review one of my own pieces.