Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should reject blocks with basefee from p2p network #485

Open
noel2004 opened this issue Aug 26, 2023 · 0 comments
Open

Should reject blocks with basefee from p2p network #485

noel2004 opened this issue Aug 26, 2023 · 0 comments
Labels
feature New feature or request invalid This doesn't seem right

Comments

@noel2004
Copy link
Member

Currently the circuit disable EIP1559 and BASEFEE op code. But it can still handle a block with base fee being set and generate the corresponding state. For example, coinbase being rewared with amount considering basefee. And such block trace would make divergenced result in circuit, finally cause a block which can not be proven. A malicous node in the p2p network would propagte such a block, and once it is commited, our chain would not be further proven later.

It is adviced that a verification should be included for empty basefee, when l2geth has received any blocks from other nodes.

@noel2004 noel2004 added invalid This doesn't seem right feature New feature or request labels Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant