Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this still active #24

Open
Popesites opened this issue Nov 8, 2021 · 9 comments
Open

Is this still active #24

Popesites opened this issue Nov 8, 2021 · 9 comments

Comments

@Popesites
Copy link

Last commit was 6 months ago, is this still maintained / current with Secret?

@levackt
Copy link
Contributor

levackt commented Nov 11, 2021

Hi @Popesites , yes until the mainnet upgrade yesterday all the samples were working.

Just now confirmed that my issue persists with the latest version of SecretJS, ie the contract example 5 is not working. I'm look into that to get it current again, and perhaps @assafmo has some idea once he has a chance to check it out too.

Either way I'll update here to close this issue once it's working, and likely also have to update the Figment Learn examples.

@monomadic
Copy link

monomadic commented Aug 1, 2022

None of these examples work any more. I mean this constructively - it's not a great look for coming to SecretNetwork as a dev and finding the official examples completely outdated and broken.

@assafmo
Copy link
Member

assafmo commented Aug 2, 2022

You're right. There's a partially working branch update-secretjs. Only steps 1-4 are working there, I need to complete 5-8.

In the meantime you can go through 1-4 and it would be awesome to get some help from the community here to complete this. Otherwise I'll try to get to it soon.

@levackt
Copy link
Contributor

levackt commented Aug 4, 2022

You're right. There's a partially working branch update-secretjs. Only steps 1-4 are working there, I need to complete 5-8.

In the meantime you can go through 1-4 and it would be awesome to get some help from the community here to complete this. Otherwise I'll try to get to it soon.

Picking this up @assafmo

@monomadic
Copy link

Steps 1-4 don't work btw. Node endpoints need updating also. Do you need help on this?

@levackt
Copy link
Contributor

levackt commented Aug 4, 2022

Steps 1-4 don't work btw. Node endpoints need updating also. Do you need help on this?

help is always welcome, but I now have 1 through 5 working in the branch I just PR'd into @assafmo 's WIP

See if that works for you as well.

Locally I have websockets and some of the keplr stuff working too, fighting a little with keplr so will backoff and circle back

@levackt
Copy link
Contributor

levackt commented Aug 4, 2022

Just updated for 7 and 8 as well, that only leaves keplr if you get there before me.
Oh and multi messages for contracts but I don't know if that can still work in the same way, might end up as a new example.
Hope that helps you get started in the meantime

@monomadic
Copy link

Thanks, I'll try these in the morning and let you know.

@levackt
Copy link
Contributor

levackt commented Aug 10, 2022

FYI @monomadic , I just pushed the original Keplr / reactjs example, so we now have one for balances and another for contracts executions.

Also switched the old multiExecute for broadcast, for multiple contract executions, or any arbitrary messages.

The only one still giving me a bit of grief is the vanilla JS Keplr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants