-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Height is always 280px for Auto Ads #379
Comments
Yeah, I'm having same issue. |
Same in Angular 8 Version 6.0.0 |
Yep same here |
did you try display inline-block? https://support.google.com/adsense/answer/9467650?hl=en |
Thanks for replying. Can see that the ad's height is as specified now (because I've coloured the background) but now there is nothing in the |
Might depend on what height you chose and how Adsense is feeling that moment lol |
Is there a specific height it should be, or some sort of setting? It's totally fine if I remove |
I ended up writing my own component uses the One thing I did learn while doing this is that the ad wrapper honors media queries. I would give this a shot if you are still having issues with this. |
Same issue here btw thanks for your work :) |
@tomfordweb can you give more explanations please ? |
any update on this guys? |
@itsrajverma This seems to work, not sure if it has any consequences: |
I am using this library with Angular 5 and as suggested, I am using ng-adsense version 5.4.3.
Width is working fine, but why height is always 280px, no matter what. Also, I tried using className property, but it also does not set class to ins element of google, instead to the ng-adsense element which has absolutely no impact
<ng-adsense [adSlot]="XXX" [display]="'block'" [adFormat]="'auto'" [width]="728" [height]="90"
className="'make-responsive'">
The text was updated successfully, but these errors were encountered: