Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Fix distributed sampler for multi GPU #3053

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Feat: Fix distributed sampler for multi GPU #3053

wants to merge 15 commits into from
+143 −20

Conversation

ori-kron-wis
Copy link
Collaborator

Update for the dataloader in case of distributed sampler

close #3047

@ori-kron-wis ori-kron-wis added the cuda tests Run test suite on CUDA label Nov 25, 2024
@ori-kron-wis ori-kron-wis added this to the scvi-tools 1.3 milestone Nov 25, 2024
@ori-kron-wis ori-kron-wis self-assigned this Nov 25, 2024
pre-commit-ci bot and others added 9 commits November 25, 2024 16:18
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
df60e27 
for more information, see https://pre-commit.ci
@ori-kron-wis
Merge remote-tracking branch 'origin/main' into Ori-Distributed-Sampl…
5d7d6bc 
…er-Fix
@ori-kron-wis
Merge branch 'main' into Ori-Distributed-Sampler-Fix
6b37bfc
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
353d444 
for more information, see https://pre-commit.ci
@ori-kron-wis
Merge remote-tracking branch 'origin/Ori-Distributed-Sampler-Fix' int…
a68ec15 
…o Ori-Distributed-Sampler-Fix
@ori-kron-wis
fix test_samplers
1e17d7f
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d63337a 
for more information, see https://pre-commit.ci
@ori-kron-wis
fix test_samplers
ca0daf0
@ori-kron-wis
Merge remote-tracking branch 'origin/Ori-Distributed-Sampler-Fix' int…
2c8b6c7 
…o Ori-Distributed-Sampler-Fix

# Conflicts:
#	tests/dataloaders/test_dataloaders.py
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.50%. Comparing base (bcd7e67) to head (dabd350).

Files with missing lines Patch % Lines
src/scvi/dataloaders/_ann_dataloader.py 44.44% 5 Missing ⚠️
src/scvi/dataloaders/_concat_dataloader.py 80.00% 1 Missing ⚠️
src/scvi/dataloaders/_samplers.py 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3053      +/-   ##
==========================================
- Coverage   84.53%   84.50%   -0.03%     
==========================================
  Files         178      178              
  Lines       15067    15084      +17     
==========================================
+ Hits        12737    12747      +10     
- Misses       2330     2337       +7
Files with missing lines Coverage Δ
src/scvi/dataloaders/_concat_dataloader.py 96.42% <80.00%> (-3.58%) ⬇️
src/scvi/dataloaders/_samplers.py 96.87% <83.33%> (-3.13%) ⬇️
src/scvi/dataloaders/_ann_dataloader.py 82.92% <44.44%> (-11.20%) ⬇️

@ori-kron-wis ori-kron-wis marked this pull request as ready for review November 28, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canergen canergen Awaiting requested review from canergen

At least 1 approving review is required to merge this pull request.

Assignees

@ori-kron-wis ori-kron-wis

Labels
cuda tests Run test suite on CUDA
Projects
None yet
Milestone
scvi-tools 1.3
Development

Successfully merging this pull request may close these issues.

Multi-GPU fails when using ConcatDataLoader
1 participant
@ori-kron-wis