Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoginRequiredMiddleware breaks LOGIN_URL is a named URL #87

Open
vkurup opened this issue Aug 19, 2020 · 0 comments · May be fixed by #88
Open

LoginRequiredMiddleware breaks LOGIN_URL is a named URL #87

vkurup opened this issue Aug 19, 2020 · 0 comments · May be fixed by #88

Comments

@vkurup
Copy link

vkurup commented Aug 19, 2020

Django says LOGIN_URL can be a URL or a named URL pattern, but LoginRequiredMiddleware assumes that it is a URL so named URL patterns don't work. I think this could be fixed by running the URL through resolve_url before redirecting.
@vkurup vkurup linked a pull request Aug 19, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support named URL patterns for LOGIN_URL caktus/django-security
1 participant
@vkurup