Cherry PR snapshot: Fix panic when hashing empty FixedSizeList Array #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Unite all references to hashbrown::HashMap by using a common type definition * Replace some use of std::collections::HashMap with hashbrown::HashMap * Replace some use of std::collections::HashMap with hashbrown::HashMap * Replace some use of std::collections::HashMap with hashbrown::HashMap * Unite all references to hashbrown::HashSet by using a common type definition * Replace some use of std::collections::HashSet with hashbrown::HashSet
* Fix record batch memory size double counting
Previously it would panic due to division by zero.
findepi
force-pushed
the
findepi/sdf/43/cherry-pr-snapshot-fix-panic-when-hashing-empty-fixedsizelist-array-dda22e
branch
from
a8932fa to
c05d38f
Compare
github-actions
bot
added
sql
logical-expr
optimizer
substrait
functions
execution
labels
Probably due to the fact that DF doesn't commit cargo.lock, the release state is not reproducible. We're likely pulling in a newer Arrow version, which has the bit_length limitation fixed.
This reverts the `Github actions: peg Rust version to 1.82 (#75)` commit because it broke the CI build.
milevin
approved these changes
Nov 26, 2024
findepi
deleted the
findepi/sdf/43/cherry-pr-snapshot-fix-panic-when-hashing-empty-fixedsizelist-array-dda22e
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would panic due to division by zero.
Copy of apache#13533 with additional cherry picks and fixes to get the build green.