-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve setup script experience #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely simpler! Though I'm not sure what level of error handling and checks you want to put in here.
As I noted in the comment the ROS ws not existing causes silent "failures" but they're not immediately obvious. Those should definitely be checked. Whereas things like me fat fingering a ros distro name probably doesn't matter...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have the one note but if you fix that I'm sound as a pound.
This PR removes all the extra arguments from the pyrobosim setup and source scripts, using prompts instead to guide the installation, and an environment file named
pyrobosim.env
to collect persistent user data in the form of environment variables.Try it out!
Closes #181