-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split pyrobosim_ros
and pyrobosim_msgs
packages into separate repos
#224
Conversation
@DLu what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submodules, my oldest and dearest friend.
So functionally this is fine, I did a quick sanity check and the docs updates look good! But dumb question - is this out of necessity or desire for separation? What exactly is going to break in the bloom process if you just kept this as folders/subfolders?
Hmm... you're right. Maybe we can just keep it all here and still go through the whole release process. There are still a few places in the Let me sleep on it for a bit, but great point, as I would love to not have to maintain two separate repos. |
OK yeah let's not do this. Good bye, PR, and thanks again @eholum! |
Lol. Always happy to have my ignorance lead to less work! Edit: whoops. Fat phone fingers... |
This PR moves the
pyrobosim_ros
andpyrobosim_msgs
packages into a separate repo (https://github.com/sea-bass/pyrobosim_ros), including them back here as submodules.This will facilitate creating releases that officially work within the ROS 2 ecosystem. See
Also updating the release to 3.0.0 as this is the last of the big changes before I try cutting a major release.