Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ini setting with special chars breaks parsing #64

Open
Aerzas opened this issue Apr 26, 2022 · 1 comment
Open

Ini setting with special chars breaks parsing #64

Aerzas opened this issue Apr 26, 2022 · 1 comment
Labels
bug

Comments

@Aerzas
Copy link

Aerzas commented Apr 26, 2022 •
edited
Loading

When an ini setting is quoted, for example xdebug.file_link_format = "phpstorm://open?file=%f&line=%l", ini_get will return a simple string without the protection quotes and Runtime::getCurrentSettings will return an invalid unqoted stringxdebug.file_link_format=phpstorm://open?file=%f&line=%l" which will break any test.

PHPUnit\Framework\Exception: PHP:  syntax error, unexpected '=' in Unknown on line 20

We could ensure string settings are wrapped in quotes.
@sebastianbergmann
Copy link
Owner

Can you send a pull request with a fix? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastianbergmann @Aerzas