Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bootstrap from dependecies #27

Open
teone opened this issue Feb 26, 2016 · 5 comments
Open

Remove bootstrap from dependecies #27

teone opened this issue Feb 26, 2016 · 5 comments

Comments

@teone
Copy link

teone commented Feb 26, 2016

Hello @sebastianha,
thanks for your awesome work with this directive!

What about removing bootstrap (css + jquery) as a dependency for this module?

I guess that if someone is looking for this directive has already bootstrap included, and if not what about including only the checkbox related style? I think it is not useful to download a full library to use just a small piece of it. What do you think about?

In case I can help with that

@sebastianha
Copy link
Owner

Hi,

as you pointed out the most people will already include bootstrap into their project and then a version without bootstrap would add duplicate code for the checkbox.

Perhaps I coult create a build process where two versions are build, one without (and with bootstrap) and one with the checkbox related style.

@teone
Copy link
Author

teone commented Mar 4, 2016

I guess this will be the best option,
but how would you handle a different bower.json? Bootstrap is listed there as a dependecy. Is that possible?

@sebastianha
Copy link
Owner

Mmmh, I don't know if there is a way to handle this. Perhaps we could create a new branch for the non-bootstrap version with a different bower.json?

@teone
Copy link
Author

teone commented Mar 5, 2016

I don't se any other way... I guess we should find a way to manage 2 different version of the same package with bower... I'll take a look and come back (hopefully with some news)...

@ghost
Copy link

ghost commented Nov 9, 2016

Why not just bump the bower package version respecting the semver and inducing a breaking change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants