-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bootstrap from dependecies #27
Comments
Hi, as you pointed out the most people will already include bootstrap into their project and then a version without bootstrap would add duplicate code for the checkbox. Perhaps I coult create a build process where two versions are build, one without (and with bootstrap) and one with the checkbox related style. |
I guess this will be the best option, |
Mmmh, I don't know if there is a way to handle this. Perhaps we could create a new branch for the non-bootstrap version with a different bower.json? |
I don't se any other way... I guess we should find a way to manage 2 different version of the same package with bower... I'll take a look and come back (hopefully with some news)... |
Why not just bump the bower package version respecting the semver and inducing a breaking change? |
Hello @sebastianha,
thanks for your awesome work with this directive!
What about removing bootstrap (css + jquery) as a dependency for this module?
I guess that if someone is looking for this directive has already bootstrap included, and if not what about including only the checkbox related style? I think it is not useful to download a full library to use just a small piece of it. What do you think about?
In case I can help with that
The text was updated successfully, but these errors were encountered: