Hash comparisons should be case insensitive #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=======================================
Coverage 71.69% 71.70%
=======================================
Files 23 23
Lines 3173 3174 +1
=======================================
+ Hits 2275 2276 +1
Misses 898 898 ☔ View full report in Codecov by Sentry. |
|
Thanks for the contribution, @m40l. This seems reasonable: but I just want to understand how you encountered the problem. Did you generate a hash with |
bennettgoble
approved these changes
Jan 20, 2024
|
Published as v3.9.3. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get-FileHash -Algorithm MD5 archive_name.tar.bz2generates an md5 hash with all caps, and the case sensitive compare tripped me up in development. Hopefully this change will be a quality of life improvement for future users.All of the supported hash's are inherently case insensitive, so this will not affect functionality.