Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove automatic major version bump #40

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Remove automatic major version bump #40

merged 1 commit into from
Jan 26, 2024

Conversation

bennettgoble
Copy link
Member

Remove workflows/bump-major.yaml to avoid setuptools_scm confusion.

Without this, publications to PyPI can end up publishing the major version instead of the expected full semver.

Remove workflows/bump-major.yaml to avoid setuptools_scm confusion.

Without this, publications to PyPI can end up publishing the major
version instead of the expected full semver.
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c05663f) 71.70% compared to head (728ff67) 71.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   71.70%   71.70%           
=======================================
  Files          23       23           
  Lines        3174     3174           
=======================================
  Hits         2276     2276           
  Misses        898      898           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bennettgoble bennettgoble merged commit f5f85ba into main Jan 26, 2024
13 checks passed
@bennettgoble bennettgoble deleted the signal/rm-bump branch January 26, 2024 00:41
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant