Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Public Docker Image in CI: issues in forks #16

Closed
e1turin opened this issue Sep 21, 2024 · 1 comment · Fixed by #17
Closed

Use Public Docker Image in CI: issues in forks #16

e1turin opened this issue Sep 21, 2024 · 1 comment · Fixed by #17
Assignees
Labels
bug Something isn't working

Comments

@e1turin
Copy link

e1turin commented Sep 21, 2024

Нужно исправить конфиг GitHub Actions, чтобы там использовался публичный образ типа vityamand/xv6, чтобы не нужно было делать дополнительные махинации с токенами и всё автоматически работало после форка (см. 1.). Стоит добавить автоматическую сборку и использование собранного образа (см. 2.).

References:

  1. main...deevroman:xv6-riscv:main
  2. https://github.com/zerebubuth/openstreetmap-cgimap/blob/master/.github/workflows/docker_2204.yml
@e1turin e1turin added the bug Something isn't working label Sep 21, 2024
vityaman added a commit that referenced this issue Sep 22, 2024
vityaman added a commit that referenced this issue Sep 22, 2024
@vityaman vityaman linked a pull request Sep 22, 2024 that will close this issue
@vityaman
Copy link

@e1turin, it is not so obvious when tests are depend on changes in this image. We use it as a basement for CI job, but do not want to push it actually until it merged into main.

vityaman added a commit that referenced this issue Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants