Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key: consider adding RSAKey, ECDSAKey and ED25519Key classes #592

Closed
lukpueh opened this issue May 31, 2023 · 1 comment
Closed

key: consider adding RSAKey, ECDSAKey and ED25519Key classes #592

lukpueh opened this issue May 31, 2023 · 1 comment

Comments

@lukpueh
Copy link
Member

lukpueh commented May 31, 2023

SSlibKey covers rsa, ecdsa and ed25519 keys in the same class, and implements verification for each key type in a simple if/elif switch (see #585). For the sake of key signature verification alone this seems reasonable.

But now #590 adds separate signers for each of these key types, which each have field for the corresponding public key object, it might make sense to consider separate public key classes. Then we could e.g. validate if a signing scheme is supported for a public key only once in the public key constructor, and in the signer only validate if the passed public key is correct.

What speaks against this is that a signer of a given key type might not support all schemes that a public key supports. This is e.g. the case for ECDSASigner.

@lukpueh
Copy link
Member Author

lukpueh commented Mar 14, 2024

But now #590 adds separate signers for each of these key types

This is no longer the case. Let's close this issue.

@lukpueh lukpueh closed this as completed Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant