Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mult-line underlining not working properly in plain renderer #529

Open
ericwb opened this issue Jul 19, 2024 · 0 comments
Open

Mult-line underlining not working properly in plain renderer #529

ericwb opened this issue Jul 19, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ericwb
Copy link
Contributor

ericwb commented Jul 19, 2024

Describe the bug
The plain renderer doesn't work properly when the location is a multi-line string.

To Reproduce
Steps to reproduce the behavior:

$ .tox/py312/bin/precli tests/unit/rules/python/stdlib/argparse/examples/argparse_add_argument_password.py --plain
PY027: Invocation of Process Using Visible Sensitive Information
  File "tests/unit/rules/python/stdlib/argparse/examples/argparse_add_argument_password.py", line 
20, in <module>
    parser.add_argument(                                                                            
    ^                                                                                               
Error: Secrets in CLI arguments are leaked to command history, logs, ps output, etc.

Found 1 errors, 0 warnings, and 0 notes in 1 files and 26 lines of code.

Expected behavior
Should underline entire multi-line

Version

precli 0.5.12.dev8
Copyright 2024 Secure Sauce LLC
License BUSL-1.1: Business Source License 1.1 <https://spdx.org/licenses/BUSL-1.1.html>
  Python 3.12.4 (main, Jun 25 2024, 11:01:48) [Clang 15.0.0 (clang-1500.3.9.4)]

Additional context

@ericwb ericwb added the bug Something isn't working label Jul 19, 2024
@ericwb ericwb changed the title Mult-line underlining no working properly in plain renderer Mult-line underlining not working properly in plain renderer Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant