From 54c424a65e66b032a0b7bfc1d11ac87fd064a964 Mon Sep 17 00:00:00 2001 From: Horacio Herrera Date: Mon, 8 Jan 2024 11:22:30 +0100 Subject: [PATCH] remove wallet accept from tests --- .github/workflows/test-desktop.yml | 4 +++- frontend/apps/desktop/playwright.config.ts | 6 +++--- .../desktop/tests/onboarding-from-scratch.e2e.ts | 12 ++++++------ 3 files changed, 12 insertions(+), 10 deletions(-) diff --git a/.github/workflows/test-desktop.yml b/.github/workflows/test-desktop.yml index 527a7cf1c..13600c443 100644 --- a/.github/workflows/test-desktop.yml +++ b/.github/workflows/test-desktop.yml @@ -108,10 +108,12 @@ jobs: VITE_DESKTOP_HOSTNAME: "http://localhost" - name: Install Playwright Browsers - run: npx playwright install --with-deps + run: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 npx playwright install --with-deps - name: Run Tests run: yarn workspace @mintter/desktop e2e + env: + CI: "1" - name: Upload Artifacts uses: actions/upload-artifact@v3 diff --git a/frontend/apps/desktop/playwright.config.ts b/frontend/apps/desktop/playwright.config.ts index 340818095..d74879a1b 100644 --- a/frontend/apps/desktop/playwright.config.ts +++ b/frontend/apps/desktop/playwright.config.ts @@ -11,12 +11,12 @@ const config: PlaywrightTestConfig = { trace: 'retain-on-failure', video: 'on', }, - retries: 2, + retries: process.env.CI ? 2 : 0, workers: 1, expect: { - timeout: 10 * 1000, + timeout: 30 * 1000, }, - timeout: 10 * 1000, + timeout: 30 * 1000, reporter: process.env.CI ? 'github' : 'html', // reporter: [ // ['list'], diff --git a/frontend/apps/desktop/tests/onboarding-from-scratch.e2e.ts b/frontend/apps/desktop/tests/onboarding-from-scratch.e2e.ts index 998c24c67..92a30d812 100755 --- a/frontend/apps/desktop/tests/onboarding-from-scratch.e2e.ts +++ b/frontend/apps/desktop/tests/onboarding-from-scratch.e2e.ts @@ -37,13 +37,13 @@ test('Onboarding from scratch', async ({onboardingPage}) => { }) await test.step('Wallet', async () => { - let elWalletBtn = await appWindow.locator('#btn-accept-wallet') + // let elWalletBtn = await appWindow.locator('#btn-accept-wallet') let elNextBtn = await appWindow.locator('#btn-next') - await elWalletBtn.click() - let elWalletSuccessMssg = await appWindow.getByText( - 'Your wallet is ready to use!', - ) - await expect(elWalletSuccessMssg).toBeVisible() + // await elWalletBtn.click() + // let elWalletSuccessMssg = await appWindow.getByText( + // 'Your wallet is ready to use!', + // ) + // await expect(elWalletSuccessMssg).toBeVisible() expect(elNextBtn).toBeInViewport() await elNextBtn.click() })