You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 28, 2018. It is now read-only.
Solution: this.maskPassword should always be defined
Reason for wanting to mutate toggleMask:
if a user has "remember password" browser feature enabled the full password will flash when they navigate to a "settings" type page. For our project we'd prefer to not have this initial flash and instead only show the characters once we have real user input.
Alternatively this could be fixed by listening to key up/down events instead of change. I think the former solution is better. I'd be more than happy to submit a PR for this. Thoughts on approach?
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If
toggleMask
is set tofalse
I cannot then set it totrue
. It throws an error thatthis.maskPassword
is not defined.Relevant line causing the issue: https://github.com/seethroughtrees/react-ux-password-field/blob/master/src/index.js#L212-L214
Solution:
this.maskPassword
should always be definedReason for wanting to mutate
toggleMask
:if a user has "remember password" browser feature enabled the full password will flash when they navigate to a "settings" type page. For our project we'd prefer to not have this initial flash and instead only show the characters once we have real user input.
Alternatively this could be fixed by listening to key up/down events instead of change. I think the former solution is better. I'd be more than happy to submit a PR for this. Thoughts on approach?
The text was updated successfully, but these errors were encountered: