Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the title issue #222

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Conversation

KavinduGama
Copy link
Contributor

Purpose

The purpose of this PR is to fix #216

Goals

Changes the authentication error

Approach

Changed the string on schema.ts

Screenshots

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

src/schemas.ts Outdated
@@ -124,7 +124,7 @@ export const MentorApplicationSchema = z.object({
});

export const MenteeCheckInSchema = z.object({
title: z.string().min(1, 'Title is required'),
title: z.string().min(1, 'Month is required'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: z.string().min(1, 'Month is required'),
month: z.string().min(1, 'Month is required'),

Change the field as well

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @KavinduGama

@anjula-sack anjula-sack merged commit d81a17f into sef-global:development Nov 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Incorrect Error Message for Month Field in Monthly Check-In Submission Form
2 participants