Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed the comma after mentee application position #231

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

thenukadinudaya
Copy link
Contributor

@thenukadinudaya thenukadinudaya commented Dec 7, 2024

Purpose

In the mentor profile, there is an issue with the display of mentee profiles who are currently working. Specifically, when the mentee's title and company name are shown, there is an extra comma appearing between the two. This comma is placed on a new line, which causes a misalignment in the profile display.
The purpose of this PR is to fix #232

Goals

remove the comma and alignment between the title and company name is adjusted

Approach

The issue was within the HTML structure of the mentor profile, the p element where the position of the mentee is shown was followed by a comma before the company name.
To resolve the issue, I edited the HTML structure by removing the comma placed directly after the

element showing the mentee’s position.

Screenshots

Checklist

  • [ x] This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • [x ] I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • [x ] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [ x] I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

@dilankavishka
Copy link
Contributor

@thenukadinudaya you have to go through the summary and fill the informations regarding the PR. please do that as well.

@thenukadinudaya
Copy link
Contributor Author

@thenukadinudaya you have to go through the summary and fill the informations regarding the PR. please do that as well.

okay ayya

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @thenukadinudaya

@anjula-sack anjula-sack merged commit cdc3413 into sef-global:development Dec 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Comma Between Title and Company Name in Mentee Profiles on Mentor Profile
3 participants