Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

The prop workspaceAddedNewDestinations is true whenever the page is reloaded #325

Open
pea opened this issue Apr 19, 2023 · 5 comments
Open

Comments

@pea
Copy link

pea commented Apr 19, 2023

The prop workspaceAddedNewDestinations is set to true whenever the page is reloaded. This is not expected behavior, as the prop should only be set to true when new destinations are added to the workspace.

Steps to Reproduce:

  1. Open the page.
  2. Reload the page.
  3. Verify that the prop workspaceAddedNewDestinations is true.

Expected Behavior:

The prop workspaceAddedNewDestinations should be false when the page is loaded. It should only be set to true when new destinations are added to the workspace.

Actual Behavior:

The prop workspaceAddedNewDestinations is set to true whenever the page is loaded, even if no new destinations have been added.

@edsonjab
Copy link
Contributor

Hi @pea thank you for your report, we start looking into this.

@edsonjab
Copy link
Contributor

Hi @pea sorry to answer late, the property workspaceAddedNewDestinations works correctly when you didn't define initialPreferences and customPreferences and finally you need to have configurated the defaultDestinationBehavior with value imply.

@pea
Copy link
Author

pea commented Jul 24, 2023

The issue was that all destinations had to be set to either true or false. I was setting them to true/ false individually. So if one was toggled on, that one should be true but the others should also be set as false.

@edsonjab
Copy link
Contributor

edsonjab commented Aug 9, 2023

Hi @pea I created a PR #347 to fix the issue with save methods

@pea
Copy link
Author

pea commented Aug 9, 2023

Thanks for jumping on that so quickly @edsonjab. I've just come back from vacation but I'll test it out today.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants