Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WebhookGitlabIssue #961

Open
amihaiemil opened this issue Feb 1, 2021 · 5 comments
Open

Implement WebhookGitlabIssue #961

amihaiemil opened this issue Feb 1, 2021 · 5 comments

Comments

@amihaiemil
Copy link
Member

Unfortunately, we cannot use GitlabIssue inside GitlabIssues.received(...) because the JSON we receive from GitLab in the webhook has too many differences compared to the JSON we receive from GitlabIssues.open(...) or GitlabIssues.getById(...).

It's also not wise to use GitlabIssues.getById(...) in GitlabWebhookEvent.issue() because this will call GitLab's API everytime Event.issue() is called in the subsequent Conversations or Steps (which is quite a lot).

@amihaiemil amihaiemil self-assigned this Feb 1, 2021
@charlesmike
Copy link

@amihaiemil this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2021-02-11T11:52:44.632959.

Estimation here is 60 minutes, that's how much you will be paid.

Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.

If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.

If you don't have time or simply don't want to work on this, you can always resign.

@charlesmike
Copy link

@amihaiemil please keep in mind that manual assignment of tickets is a bad practice and it is discouraged. Next time, please let me elect the assignee.

@amihaiemil amihaiemil added the bug Something isn't working label Feb 1, 2021
@amihaiemil amihaiemil changed the title Implement ReceivedGitlabIssue Implement WebhookGitlabIssue Feb 1, 2021
@amihaiemil
Copy link
Member Author

amihaiemil commented Feb 1, 2021

Let's leave it for later and just cache the Issue fetched by GitlabWebhookEvent.issue(), for now. #963

@amihaiemil
Copy link
Member Author

@charlesmike remove

@charlesmike
Copy link

@charlesmike remove

@amihaiemil ok, I've removed this task from scope. I'm not managing it anymore.

@amihaiemil amihaiemil removed the bug Something isn't working label Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants