-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement WebhookGitlabIssue #961
Comments
@amihaiemil this is your task now, please go ahead. Deadline (when this ticket should be closed) is Estimation here is Remember, you don't have to solve everything in this ticket - you can solve it partially and leave If you have any questions don't ask me, I'm not a technical person. Open new tickets instead. If you don't have time or simply don't want to work on this, you can always resign. |
@amihaiemil please keep in mind that manual assignment of tickets is a bad practice and it is discouraged. Next time, please let me elect the assignee. |
Let's leave it for later and just cache the Issue fetched by GitlabWebhookEvent.issue(), for now. #963 |
@charlesmike remove |
@amihaiemil ok, I've removed this task from scope. I'm not managing it anymore. |
Unfortunately, we cannot use GitlabIssue inside GitlabIssues.received(...) because the JSON we receive from GitLab in the webhook has too many differences compared to the JSON we receive from GitlabIssues.open(...) or GitlabIssues.getById(...).
It's also not wise to use GitlabIssues.getById(...) in GitlabWebhookEvent.issue() because this will call GitLab's API everytime Event.issue() is called in the subsequent Conversations or Steps (which is quite a lot).
The text was updated successfully, but these errors were encountered: