Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: build components sequentially #821

Merged
merged 1 commit into from
Jul 11, 2024
Merged

build: build components sequentially #821

merged 1 commit into from
Jul 11, 2024

Conversation

cedoor
Copy link
Member

@cedoor cedoor commented Jul 10, 2024

Description

As mentioned here: #808 (comment), the build script was not working correctly after #810.

yarn workspaces foreach --topological-dev doesn't detect some (dev)dependencies. This PR runs the build scripts sequentially (it should not affect the execution time that much).

Additionally, the Semaphore ABI JSON file is now imported from the @semaphore-protocol/utils package directly in the subgraph.

Related Issue(s)

Re #808

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@cedoor cedoor requested a review from a team as a code owner July 10, 2024 10:03
Copy link

build: build components sequentially

Generated at commit: c1c8d05943dcca3323b4cd4150d76137a99793d6

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
0
0
0
4
15
19
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link
Contributor

@0xjei 0xjei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine on my end - tysm!

@cedoor cedoor requested a review from sripwoud July 10, 2024 14:36
Copy link
Contributor

@sripwoud sripwoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK (run yarn build locally)

@cedoor cedoor merged commit 0f6505c into main Jul 11, 2024
5 checks passed
@cedoor cedoor deleted the build/rollback branch July 11, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants