Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comments not filtered on generic mode, rule: use-frozen-lockfile-npm #3039

Closed
nashcontrol opened this issue Aug 13, 2023 · 0 comments · Fixed by #3040
Closed

comments not filtered on generic mode, rule: use-frozen-lockfile-npm #3039

nashcontrol opened this issue Aug 13, 2023 · 0 comments · Fixed by #3040
Labels
bug Something isn't working

Comments

@nashcontrol
Copy link
Contributor

When specifying options.generic_comment_style: shell, comments starting with # should be filtered from the results.

https://semgrep.dev/playground/s/peL0

Expected behavior
Shell style comments in dockerfile should be ignored
@nashcontrol nashcontrol added the bug Something isn't working label Aug 13, 2023
@inkz inkz mentioned this issue Aug 14, 2023
Merged
@inkz inkz linked a pull request Aug 14, 2023 that will close this issue
update use-frozen-lockfile rule #3040
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update use-frozen-lockfile rule semgrep/semgrep-rules
1 participant
@nashcontrol