Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After sending pause signal (USR2) SerialWorker performs a job before it actually pauses #234

Open
berkcaputcu opened this issue May 20, 2015 · 0 comments
Open

After sending pause signal (USR2) SerialWorker performs a job before it actually pauses #234

berkcaputcu opened this issue May 20, 2015 · 0 comments

Comments

@berkcaputcu
Copy link

Since the check for paused worker is inside the jobs loop (/lib/qless/worker/serial.rb#L25-L36), SerialWorker needs to perform a job before it knows it's paused.

This check should be done before the reserver reserves a job, so the worker can be paused before it takes a job.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pause worker before it reserves a job Shopify/qless
1 participant
@berkcaputcu