Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachment being considered file (compatibility with PA 10) #2262

Closed
aberenguel opened this issue Jul 17, 2024 · 14 comments
Closed

Attachment being considered file (compatibility with PA 10) #2262

aberenguel opened this issue Jul 17, 2024 · 14 comments
Assignees
@aberenguel
Labels
enhancement

Comments

@aberenguel
Copy link
Contributor

I processed an UFDR file generated by Physical Analyzer 10.2.

The result is that instant messages got from DecodedData are being considered files (same contentType, hash).
This behavior first appeared after #2028 fix.

image
@aberenguel aberenguel changed the title Instant messages being considered as files Instant messages being considered files Jul 17, 2024
@lfcnassif lfcnassif mentioned this issue Jul 17, 2024
Merged
@marcosammoura
Copy link
Contributor

marcosammoura commented Jul 17, 2024 •
edited
Loading

Checking the reported issue

@lfcnassif
Copy link
Member

@aberenguel, looking closer at your picture, the name of those items listed in the duplicates tab starts with Attachment_XXXXX, they seem to be subitems of the InstantMessage_XXXX items, according to their path. So, maybe the new behavior is correct. Could you check in the chats if those instant messages display as media messages and also confirm that displaying using Cellebrite Reader?

@aberenguel
Copy link
Contributor Author

My mistake. Actually Attachment are being considered file.
I reprocessed two UFDRs from the same extraction (one with PA 7 and another with PA10).

With PA 7
image

With PA 10
image

@aberenguel aberenguel changed the title Instant messages being considered files Attachment being considered file Jul 19, 2024
@aberenguel
Copy link
Contributor Author

Could you check in the chats if those instant messages display as media messages and also confirm that displaying using Cellebrite Reader?

I'll check this weekend. My Windows machine is crashed.

@aberenguel
Copy link
Contributor Author

aberenguel commented Jul 19, 2024 •
edited
Loading

Part of report.xml from PA 7:

<file fs="EXTRACTION_FFS.zip" fsid="3c19b9e3-c5db-4e1a-8239-d6cf68f22bbb" path="/data/media/0/Android/data/org.telegram.messenger/files/Telegram/Telegram Video/1_4983387851321246717.mp4" size="11617721" id="ed538543-e8df-40fa-bfd7-af99c81f6602" extractionId="0" deleted="Intact" embedded="false" isrelated="False" decodedBy="System" source_index="89250">
  <accessInfo>
    <timestamp name="ModifyTime" format="TimeStampKnown" formattedTimestamp="2023-10-10T21:19:24+00:00">2023-10-10T21:19:24.000+00:00</timestamp>
  </accessInfo>
  <metadata section="File">
    <item name="Local Path" systemtype="System.String"><![CDATA[files\Video\1_4983387851321246717.mp4]]></item>
    <item name="SHA256" systemtype="System.String"><![CDATA[]]></item>
    <item name="MD5" systemtype="System.String"><![CDATA[7e6f473c66c3772fcab21d46e3fcfd1a]]></item>
    <item name="Tags" systemtype="System.String"><![CDATA[Video]]></item>
  </metadata>
  <metadata section="MetaData">
    <item name="CoreFileSystemFileSystemNodeFileDataOffsetName" group="CoreFileSystemFileSystemNodeFileOffsetsCategory" systemtype="System.String"><![CDATA[0x5501C5BA5]]></item>
    <item name="CoreFileSystemFileSystemNodeCreationTime" group="CoreFileSystemFileSystemNodeDateTime" systemtype="System.String"><![CDATA[]]></item>
    <item name="CoreFileSystemFileSystemNodeModifyTime" group="CoreFileSystemFileSystemNodeDateTime" systemtype="System.String"><![CDATA[10/10/2023 21:19:24(UTC+0)]]></item>
    <item name="CoreFileSystemFileSystemNodeLastAccessTime" group="CoreFileSystemFileSystemNodeDateTime" systemtype="System.String"><![CDATA[]]></item>
    <item name="CoreFileSystemFileSystemNodeDeletedTime" group="CoreFileSystemFileSystemNodeDateTime" systemtype="System.String"><![CDATA[]]></item>
    <item name="CoreFileSystemFileSystemNodeChangeTime" group="CoreFileSystemFileSystemNodeDateTime" systemtype="System.String"><![CDATA[]]></item>
    <item name="ReportTemplateFileSize" systemtype="System.String"><![CDATA[11617721 Bytes]]></item>
    <item name="CoreFileSystemFileSystemNodeFileChunks" systemtype="System.String"><![CDATA[1]]></item>
  </metadata>
  <sourcemodels>
    <ownerid direction="Incoming" type="InstantMessage"><![CDATA[58b33ac5-231c-4b60-bbd3-e408f9a9380a]]></ownerid>
    <ownerid direction="Incoming" type="InstantMessage"><![CDATA[6d570ee2-f011-49de-82cf-5c986f8023dc]]></ownerid>
    <ownerid direction="Incoming" type="InstantMessage"><![CDATA[27489ab4-a2b9-4473-89d6-00b3be46c30d]]></ownerid>
  </sourcemodels>
  <jumptargets name="">
    <targetid ismodel="true"><![CDATA[58b33ac5-231c-4b60-bbd3-e408f9a9380a]]></targetid>
    <targetid ismodel="true"><![CDATA[6d570ee2-f011-49de-82cf-5c986f8023dc]]></targetid>
    <targetid ismodel="true"><![CDATA[27489ab4-a2b9-4473-89d6-00b3be46c30d]]></targetid>
  </jumptargets>
</file>

<model type="InstantMessage" id="6d570ee2-f011-49de-82cf-5c986f8023dc" deleted_state="Intact" decoding_confidence="High" isrelated="False" source_index="104235" extractionId="0">
  <field name="UserMapping" type="DecodingSourceOptions">
    <value type="DecodingSourceOptions"><![CDATA[Decoding]]></value>
  </field>
  <field name="Source" type="String">
    <value type="String"><![CDATA[Telegram]]></value>
  </field>
  <field name="ServiceIdentifier" type="String">
    <empty />
  </field>
  <modelField name="From" type="Party">
    <model type="Party" id="841aa42a-e236-4f43-9b89-c930ade2a4bd" deleted_state="Unknown" decoding_confidence="High" isrelated="False" source_index="104236" extractionId="0">
      <field name="Identifier" type="String">
        <value type="String"><![CDATA[1919626957]]></value>
      </field>
      <field name="Role" type="PartyRole">
        <value type="PartyRole"><![CDATA[From]]></value>
      </field>
      <field name="Name" type="String">
        <empty />
      </field>
      <multiField name="IPAddresses" type="String" />
      <field name="IsPhoneOwner" type="Boolean">
        <value type="Boolean"><![CDATA[False]]></value>
      </field>
      <field name="IsGroupAdmin" type="Boolean">
        <empty />
      </field>
    </model>
  </modelField>
  <multiModelField name="To" type="Party" />
  <field name="Body" type="String">
    <value type="String"><![CDATA[Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.]]></value>
  </field>
  <field name="Identifier" type="String">
    <value type="String"><![CDATA[-1919626957:427]]></value>
  </field>
  <field name="TimeStamp" type="TimeStamp">
    <value type="TimeStamp" format="TimeStampKnown" formattedTimestamp="2023-10-10T21:06:52+00:00">2023-10-10T21:06:52.000+00:00</value>
  </field>
  <modelField name="Attachment" type="Attachment">
    <empty />
  </modelField>
  <multiModelField name="Attachments" type="Attachment">
    <model type="Attachment" id="8031eda5-90ce-46f2-ac63-51c8be978d05" deleted_state="Intact" decoding_confidence="High" isrelated="False" source_index="104238" extractionId="0" file_id="ed538543-e8df-40fa-bfd7-af99c81f6602">
      <field name="Filename" type="String">
        <value type="String"><![CDATA[1_4983387851321246717.mp4]]></value>
      </field>
      <field name="ContentType" type="String">
        <value type="String"><![CDATA[video/mp4]]></value>
      </field>
      <dataField name="Data" type="MemoryRange">
        <source length="11617721" />
      </dataField>
      <field name="URL" type="String">
        <empty />
      </field>
      <field name="Title" type="String">
        <empty />
      </field>
      <field name="attachment_extracted_path" type="String">
        <value type="String"><![CDATA[files\Video\1_4983387851321246717.mp4]]></value>
      </field>
    </model>
  </multiModelField>
  <field name="Status" type="MessageStatus">
    <value type="MessageStatus"><![CDATA[Unread]]></value>
  </field>
  <multiModelField name="SharedContacts" type="Contact" />
  <multiModelField name="MessageExtraData" type="InstantMessageExtraData">
    <model type="MessageLabel" id="d80187a7-3ce1-4644-9892-dcb1529fc3ce" deleted_state="Unknown" decoding_confidence="High" isrelated="False" source_index="104237" extractionId="0">
      <field name="Label" type="Label">
        <value type="Label"><![CDATA[Edited]]></value>
      </field>
    </model>
  </multiModelField>
  <field name="Type" type="InstantMessageType">
    <value type="InstantMessageType"><![CDATA[AppMessage]]></value>
  </field>
  <field name="IsLocationSharing" type="Boolean">
    <empty />
  </field>
  <field name="SourceApplication" type="String">
    <value type="String"><![CDATA[Telegram]]></value>
  </field>
  <jumptargets name="">
    <targetid ismodel="false"><![CDATA[ed538543-e8df-40fa-bfd7-af99c81f6602]]></targetid>
  </jumptargets>
</model>

@aberenguel
Copy link
Contributor Author

aberenguel commented Jul 19, 2024 •
edited
Loading

Part of report.xml from PA 10:

<file fs="EXTRACTION_FFS.zip" fsid="eb45688c-8048-44f3-9b61-371565784dc9" path="/data/media/0/Android/data/org.telegram.messenger/files/Telegram/Telegram Video/1_4983387851321246717.mp4" name="1_4983387851321246717.mp4" size="11617721" id="47071582-c602-49bb-9944-15c3a314d8aa" extractionId="0" deleted="Intact" embedded="false" isrelated="False" source_index="87951">
  <accessInfo>
    <timestamp name="ModifyTime" format="TimeStampKnown" formattedTimestamp="2023-10-10T21:19:24+00:00">2023-10-10T21:19:24.000+00:00</timestamp>
  </accessInfo>
  <metadata section="File">
    <item name="Local Path" systemtype="System.String"><![CDATA[files\Video\1_4983387851321246717.mp4]]></item>
    <item name="SHA256" systemtype="System.String"><![CDATA[20f88a26a1b724f4102156135badc1b040ca98f10839b4313c181919a11275ac]]></item>
    <item name="MD5" systemtype="System.String"><![CDATA[7e6f473c66c3772fcab21d46e3fcfd1a]]></item>
    <item name="Tags" systemtype="System.String"><![CDATA[Video]]></item>
    <item name="CapturingDevice" systemtype="System.String"><![CDATA[External]]></item>
    <item name="CaptureOriginReasoning" systemtype="System.String"><![CDATA[Received]]></item>
    <item name="CaptureOriginReasoning" systemtype="System.String"><![CDATA[Downloaded]]></item>
  </metadata>
  <metadata section="MetaData">
    <item name="CoreFileSystemFileSystemNodeChangeTime" group="CoreFileSystemFileSystemNodeDateTime" systemtype="System.String"><![CDATA[]]></item>
    <item name="CoreFileSystemFileSystemNodeCreationTime" group="CoreFileSystemFileSystemNodeDateTime" systemtype="System.String"><![CDATA[]]></item>
    <item name="CoreFileSystemFileSystemNodeDeletedTime" group="CoreFileSystemFileSystemNodeDateTime" systemtype="System.String"><![CDATA[]]></item>
    <item name="CoreFileSystemFileSystemNodeFileChunks" systemtype="System.String"><![CDATA[1]]></item>
    <item name="CoreFileSystemFileSystemNodeFileDataOffsetName" group="CoreFileSystemFileSystemNodeFileOffsetsCategory" systemtype="System.String"><![CDATA[0x5501C5BA5]]></item>
    <item name="CoreFileSystemFileSystemNodeFilePath" systemtype="System.String"><![CDATA[EXTRACTION_FFS.zip/data/media/0/Android/data/org.telegram.messenger/files/Telegram/Telegram Video/1_4983387851321246717.mp4]]></item>
    <item name="CoreFileSystemFileSystemNodeLastAccessTime" group="CoreFileSystemFileSystemNodeDateTime" systemtype="System.String"><![CDATA[]]></item>
    <item name="CoreFileSystemFileSystemNodeModifyTime" group="CoreFileSystemFileSystemNodeDateTime" systemtype="System.String"><![CDATA[10/10/2023 18:19:24(UTC-3)]]></item>
    <item name="QuickTimeMovieEnumCreated" group="EXIF" systemtype="System.String"><![CDATA[ter out 10 21:06:56 2023]]></item>
    <item name="QuickTimeTrackEnumCreated" group="EXIF" systemtype="System.String"><![CDATA[ter out 10 21:06:43 2023]]></item>
  </metadata>
  <sourcemodels>
    <ownerid direction="Incoming"><![CDATA[9dab2cda-100a-4054-98d1-df08be783e7a]]></ownerid>
    <ownerid direction="Incoming"><![CDATA[f94f50ad-30ff-4d51-81b9-6b972c8f72cb]]></ownerid>
    <ownerid direction="Incoming"><![CDATA[750096b7-c2a3-4e54-9291-9002d6422f02]]></ownerid>
  </sourcemodels>
</file>

<model type="InstantMessage" id="bd63e606-355f-4e3e-98fa-095b09bc7e8d" deleted_state="Intact" decoding_confidence="High" isrelated="False" source_index="104405" extractionId="0">
  <field name="UserMapping" type="DecodingSourceOptions">
    <value type="DecodingSourceOptions"><![CDATA[Decoding]]></value>
  </field>
  <field name="Source" type="String">
    <value type="String"><![CDATA[Telegram]]></value>
  </field>
  <modelField name="From" type="Party">
    <model type="Party" id="623b8eca-ddff-4424-ba04-4330bb1cb44a" deleted_state="Unknown" decoding_confidence="High" isrelated="False" source_index="104406" extractionId="0">
      <field name="Identifier" type="String">
        <value type="String"><![CDATA[1919626957]]></value>
      </field>
      <field name="Role" type="PartyRole">
        <value type="PartyRole"><![CDATA[From]]></value>
      </field>
      <field name="Status" type="PartyStatus">
        <value type="PartyStatus"><![CDATA[Unknown]]></value>
      </field>
      <field name="Name" type="String">
        <value type="String"><![CDATA[XXXXXXXXXXXXXXXXXXXXXX]]></value>
      </field>
      <field name="Distance" type="Double">
        <value type="Double"><![CDATA[0]]></value>
      </field>
      <field name="IsPhoneOwner" type="Boolean">
        <value type="Boolean"><![CDATA[False]]></value>
      </field>
      <field name="IsGroupAdmin" type="Boolean">
        <value type="Boolean"><![CDATA[False]]></value>
      </field>
    </model>
  </modelField>
  <field name="Body" type="String">
    <value type="String"><![CDATA[Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.]]></value>
  </field>
  <field name="TimeStamp" type="TimeStamp">
    <value type="TimeStamp" format="TimeStampKnown" formattedTimestamp="2023-10-10T21:06:55+00:00">2023-10-10T21:06:55.000+00:00</value>
  </field>
  <modelField name="Attachment" type="Attachment">
    <empty />
  </modelField>
  <multiModelField name="Attachments" type="Attachment">
    <model type="Attachment" id="48f59070-37bd-4e1c-89f9-73dab5b63f1b" deleted_state="Intact" decoding_confidence="High" isrelated="False" source_index="104409" extractionId="0" file_id="47071582-c602-49bb-9944-15c3a314d8aa">
      <field name="Source" type="String">
        <empty />
      </field>
      <field name="Filename" type="String">
        <value type="String"><![CDATA[1_4983387851321246717.mp4]]></value>
      </field>
      <field name="ContentType" type="String">
        <value type="String"><![CDATA[video/mp4]]></value>
      </field>
      <dataField name="Data" type="MemoryRange">
        <source length="11617721" />
      </dataField>
      <field name="attachment_extracted_path" type="String">
        <value type="String"><![CDATA[files\Video\1_4983387851321246717_33679.mp4]]></value>
      </field>
    </model>
  </multiModelField>
  <field name="Status" type="MessageStatus">
    <value type="MessageStatus"><![CDATA[Unread]]></value>
  </field>
  <multiModelField name="SharedContacts" type="Contact" />
  <field name="Label" type="Label">
    <value type="Label"><![CDATA[Default]]></value>
  </field>
  <field name="Platform" type="Platform">
    <value type="Platform"><![CDATA[Unknown]]></value>
  </field>
  <multiModelField name="MessageExtraData" type="InstantMessageExtraData">
    <model type="MessageLabel" id="42fe7360-2fcc-4add-84b6-708773605a1e" deleted_state="Intact" decoding_confidence="High" isrelated="False" source_index="104407" extractionId="0">
      <field name="Label" type="Label">
        <value type="Label"><![CDATA[Edited]]></value>
      </field>
    </model>
    <model type="ForwardedMessageData" id="3dffdc35-ab5f-43c3-b350-cade829529e8" deleted_state="Intact" decoding_confidence="High" isrelated="False" source_index="104408" extractionId="0">
      <field name="Label" type="Label">
        <value type="Label"><![CDATA[Forwarded]]></value>
      </field>
      <field name="TimeCreated" type="TimeStamp">
        <value type="TimeStamp" format="TimeStampKnown" formattedTimestamp="2023-10-10T21:06:52+00:00">2023-10-10T21:06:52.000+00:00</value>
      </field>
      <modelField name="OriginalSender" type="Party">
        <model type="Party" id="0ccc0a4a-e938-442e-8c20-83a0616c40e7" deleted_state="Unknown" decoding_confidence="High" isrelated="False" source_index="104410" extractionId="0">
          <field name="Identifier" type="String">
            <value type="String"><![CDATA[1919626957]]></value>
          </field>
          <field name="Role" type="PartyRole">
            <value type="PartyRole"><![CDATA[From]]></value>
          </field>
          <field name="Status" type="PartyStatus">
            <value type="PartyStatus"><![CDATA[Unknown]]></value>
          </field>
          <field name="Name" type="String">
            <value type="String"><![CDATA[XXXXXXXXXXXXXXXXXXXXXX]]></value>
          </field>
          <field name="Distance" type="Double">
            <value type="Double"><![CDATA[0]]></value>
          </field>
          <field name="IsPhoneOwner" type="Boolean">
            <value type="Boolean"><![CDATA[False]]></value>
          </field>
          <field name="IsGroupAdmin" type="Boolean">
            <value type="Boolean"><![CDATA[False]]></value>
          </field>
        </model>
      </modelField>
    </model>
  </multiModelField>
  <field name="Type" type="InstantMessageType">
    <value type="InstantMessageType"><![CDATA[AppMessage]]></value>
  </field>
  <field name="Priority" type="MailPriority">
    <value type="MailPriority"><![CDATA[Normal]]></value>
  </field>
  <field name="SelfDestructDuration" type="TimeSpan">
    <value type="TimeSpan"><![CDATA[00:00:00]]></value>
  </field>
  <field name="IsLocationSharing" type="Boolean">
    <value type="Boolean"><![CDATA[False]]></value>
  </field>
  <field name="Identifier" type="String">
    <value type="String"><![CDATA[1811718519:5562]]></value>
  </field>
  <field name="SourceApplication" type="String">
    <value type="String"><![CDATA[Telegram]]></value>
  </field>
  <jumptargets name="">
    <targetid ismodel="false" targetType="File"><![CDATA[47071582-c602-49bb-9944-15c3a314d8aa]]></targetid>
  </jumptargets>
</model>

@aberenguel
Copy link
Contributor Author

aberenguel commented Jul 19, 2024 •
edited
Loading

I pasted just one InstantMessage from each report.xml in the comments above. Actually there are 3 of them.

@aberenguel
Copy link
Contributor Author

With PA 10 image

The path of items named as InstantMessage_XXX are

xxx.ufdr/_decodeddata/chat/chat_89b7dd77-c251-4340-be14-b7c707f80dfb/instantmessage_0bc5ca71-9ab0-4559-933d-e3e54a4cf288/replymessagedata_616b9f91-521f-4f8f-b7ea-dc514daf930d/instantmessage_bd63e606-355f-4e3e-98fa-095b09bc7e8d
xxx.ufdr/_decodeddata/chat/chat_89b7dd77-c251-4340-be14-b7c707f80dfb/instantmessage_3ad616ff-036d-42d5-b1bf-26c3e29d2d43/replymessagedata_a3bfaf4d-12f2-47fd-a786-f71ea6506975/instantmessage_5cc3adfc-2c95-40c9-9abd-41d66ebf38bf/replymessagedata_6cc0f211-fccc-4891-9443-dd7510d1a6f3/instantmessage_bd63e606-355f-4e3e-98fa-095b09bc7e8d
xxx.ufdr/_decodeddata/chat/chat_89b7dd77-c251-4340-be14-b7c707f80dfb/instantmessage_3f35f583-7b44-423f-984a-1342dc7ff142/replymessagedata_cc5c598b-d670-4b88-9735-bb37ccf72fe6/instantmessage_0bc5ca71-9ab0-4559-933d-e3e54a4cf288/replymessagedata_616b9f91-521f-4f8f-b7ea-dc514daf930d/instantmessage_bd63e606-355f-4e3e-98fa-095b09bc7e8d
xxx.ufdr/_decodeddata/chat/chat_89b7dd77-c251-4340-be14-b7c707f80dfb/instantmessage_5364f89b-9dce-48c5-ae69-8c546c93cd11/replymessagedata_e542427e-02b1-46c0-9150-d75267edf90c/instantmessage_bd63e606-355f-4e3e-98fa-095b09bc7e8d
xxx.ufdr/_decodeddata/chat/chat_89b7dd77-c251-4340-be14-b7c707f80dfb/instantmessage_5cc3adfc-2c95-40c9-9abd-41d66ebf38bf/replymessagedata_6cc0f211-fccc-4891-9443-dd7510d1a6f3/instantmessage_bd63e606-355f-4e3e-98fa-095b09bc7e8d
xxx.ufdr/_decodeddata/chat/chat_89b7dd77-c251-4340-be14-b7c707f80dfb/instantmessage_96b427e2-89bd-4f97-9e1b-3429ac6f23a3/replymessagedata_28ed7a39-6b33-492d-b4f7-c1ec2d2f662c/instantmessage_bd63e606-355f-4e3e-98fa-095b09bc7e8d

aberenguel added a commit to aberenguel/IPED that referenced this issue Jul 19, 2024
@aberenguel
sepinf-inc#2262: if extracted_path does not reference a ufedId, use t…
f52a7f3 
…he ufedId of attached file
@aberenguel
Copy link
Contributor Author

Talking to @marcosammoura, this bug happens due to the existence of duplicated files inside UFDR.
Related to the example above:

 11617721  2023-10-10 18:19   files/Video/1_4983387851321246717.mp4
 11617721  2023-10-10 18:19   files/Video/1_4983387851321246717_33679.mp4
 11617721  2023-10-10 18:19   files/Video/1_4983387851321246717_33694.mp4
 11617721  2023-10-10 18:19   files/Video/1_4983387851321246717_33698.mp4

This might be related to a bug in Physical Analyzer.

@aberenguel
Copy link
Contributor Author

I've just checked a new UFDR generated by PA 10.3. In such case, the PA 10.3 solved the problem of duplicated files. The attachment_extracted_path property references the non-duplicated file (in the example above, the property value is files\Video\1_4983387851321246717.mp4).

The fix of #2149 solves the issue when attachment_extracted_path references non-existent files. But when attachment_extracted_path references an existent file in UFDR but not referenced to a file of report.xml, the commit f52a7f3 solves the problem. Both scenarios apparently occur in UFDR files generated by PA 8.x until 10.2.

@lfcnassif
Copy link
Member

Not sure if I completely understood the situation here. Could someone elaborate more on what is the issue and how the proposed PR fix it?

@aberenguel
Copy link
Contributor Author

aberenguel commented Aug 8, 2024 •
edited
Loading

This proposal targets UFDR files generated by PA 8.x until 10.2.

Those UFDRs files have fields attachment_extracted_path of Attachment model with values not stored in UfedXmlReader.ufdrPathToUfedId map.

Some examples of attachment_extracted_path values:

files/Video/1_4983387851321246717.mp4
files/Video/1_4983387851321246717_33679.mp4
files/Video/1_4983387851321246717_33694.mp4
files/Video/1_4983387851321246717_33698.mp4

Only the first one is added UfedXmlReader.ufdrPathToUfedId when processing the File model. Btw, all those files above has the same content.

@aberenguel
Copy link
Contributor Author

aberenguel commented Aug 8, 2024 •
edited
Loading

I wonder if UfedXmlReader.ufdrPathToUfedId is really necessary. The ufedId returned in UfedXmlReader.handleAttachment can always be retrieved by item.getMetadata().get(FILE_ID_ATTR)

@aberenguel
Copy link
Contributor Author

This issue will be handled in #2286 UfedChatParser refactoring.

lfcnassif added a commit that referenced this issue Oct 13, 2024
@lfcnassif
Merge pull request #2263 from aberenguel/2262_fix_handleAttachment
cdb5ebe 
#2262: if extracted_path does not reference a ufedId, use the ufedId of attached file
@lfcnassif lfcnassif added the bug label Dec 30, 2024
@lfcnassif lfcnassif changed the title Attachment being considered file Attachment being considered file (compatibility with PA 10) Dec 30, 2024
@lfcnassif lfcnassif added enhancement and removed bug labels Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aberenguel aberenguel

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aberenguel @lfcnassif @marcosammoura