Cap sampling ratio to make sure gl.VertexAttribIPointer stride is valid

seqsense · Nov 20, 2024 · df33469 · df33469
1 parent 97c5aa6
commit df33469
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/main_js.go b/main_js.go
@@ -716,13 +716,20 @@ L_MAIN:
 			samplingRatio := 1
 			if pe.vi.dragging() {
 				totalPoints := 0
+				maxStride := 4
 				if hasPointCloud && pp.Points > 0 {
 					totalPoints += pp.Points
+					maxStride = max(pp.Stride(), maxStride)
 				}
 				if hasSubPointCloud && ppSub.Points > 0 && selectMode == selectModeInsert {
 					totalPoints += ppSub.Points
+					maxStride = max(ppSub.Stride(), maxStride)
 				}
 				samplingRatio = 1 + totalPoints/pe.cmd.NumFastRenderPoints()
+				// make sure the stride used in gl.VertexAttribIPointer is <= 255
+				if samplingRatio*maxStride > 255 {
+					samplingRatio = int(255.0 / maxStride)
+				}
 			}
 
 			if hasPointCloud && pp.Points > 0 {