Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Google Maps Reviews API] Return an empty string instead of "\"\"" when the user.name or snippet fields are empty #2115

Open
martin-serpapi opened this issue Nov 11, 2024 · 3 comments
Labels
status: freezer Something we don't want to work on yet type: improvement Something needs to be improved

Comments

@martin-serpapi
Copy link

A customer requested that we return an empty string instead of a "\"\"" value when the user.name or snippet fields are empty:

image

Playground | Inspect

Intercom

@martin-serpapi martin-serpapi added status: freezer Something we don't want to work on yet type: improvement Something needs to be improved labels Nov 11, 2024
@schaferyan
Copy link
Contributor

Thanks @martin-serpapi. My guess is we will want to omit this field when it's empty, rather than provide an empty string, as that's more in line with our usual practice for fields not present in the response.

@marm123
Copy link

marm123 commented Nov 14, 2024

I think it might be a valid concern on the one hand, but on the other hand, we're scraping the data as is, and since it's the name is posted as "" on Google, should we alter that on our end? Should we also consider other cases where the other fields might seem odd on Google's side?

My initial thought is that since Google provides the information this way, we should also scrape it as is and leave the data manipulation to our users. I might be wrong, though. What do you think, @martin-serpapi @schaferyan?

@schaferyan
Copy link
Contributor

@marm123 from looking at the screenshot, I initially thought there was just no username for the review. But looking more closely, I see that Google actually displays those quotation marks. While it seems like odd behavior and potentially a bug on Google's side, I agree that if that's what Google displays, it's also what we should return.
Screenshot 2024-11-14 at 11 38 44 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: freezer Something we don't want to work on yet type: improvement Something needs to be improved
Projects
None yet
Development

No branches or pull requests

3 participants