Added Playground to demonstrate and test compatibility #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ffried
requested changes
Apr 30, 2019
| @@ -0,0 +1 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?><Workspace version="1.0"> <FileRef location="group:Zip.playground.xcworkspace/Playground.playground/"></FileRef> <FileRef location="group:/Users/CalQL8ed-K-OS/Workbench/open-source/Zip/./Zip.xcodeproj"></FileRef></Workspace> | |||
There was a problem hiding this comment.
We can't merge this as is, since it contains absolute paths here. That won't work on other machines.
How about we just mention playground support in the README? The command you used to create it could be there as well.
Adding a playground also means that it has to be kept up to date.
|
That's fine, I leave it up to you entirely, I just wanted to share the
proof. Good to know that the to uses absolute references, that's something
we should change.
…On Tue, Apr 30, 2019, 05:46 Florian Friedrich ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In Zip.playground.xcworkspace/contents.xcworkspacedata
<#2 (comment)>:
> @@ -0,0 +1 @@
+<?xml version="1.0" encoding="UTF-8"?><Workspace version="1.0"> <FileRef location="group:Zip.playground.xcworkspace/Playground.playground/"></FileRef> <FileRef location="group:/Users/CalQL8ed-K-OS/Workbench/open-source/Zip/./Zip.xcodeproj"></FileRef></Workspace>
We can't merge this as is, since it contains absolute paths here. That
won't work on other machines.
How about we just mention playground support in the README? The command
you used to create it could be there as well.
Adding a playground also means that it has to be kept up to date.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACJJS2PO76UQ43U5O2F3G3PTAIOTANCNFSM4HJFWXXA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI This playground was created using John Sundell's Playground CLI Tool, specifically the command was
playground -t Zip.playground -d ./Zip.xcodeproj