Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement suggestion: set GZIP compression to true when creating Cloudfront distribution #71

Open
oussj opened this issue Nov 29, 2020 · 1 comment

Comments

@oussj
Copy link

oussj commented Nov 29, 2020

Hello!

Most of the suggestion is in the title. When I audited with Lighthouse my static website deployed with the serverless website component, I found out that I had a lot to win by gzipping my assets.

Gzipping is not enabled by default when creating the distribution as I could see it here

I suggest to set this value to true by default instead of false

Otherwise, if for some reason the default behaviour should not change, I suggest adding it as an optional input in the serverless.yml file

I'd be happy to do the pull request.

@fulminant
Copy link

@eahefnawy, hello.
Could you, please, take a look at this PR. I guess the compression feature will be very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants