Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Use NonZeroU16 for port numbers #930

Open
DonIsaac opened this issue May 18, 2024 · 0 comments · May be fixed by #933
Open

perf: Use NonZeroU16 for port numbers #930

DonIsaac opened this issue May 18, 2024 · 0 comments · May be fixed by #933

Comments

@DonIsaac
Copy link

Changing URL's port field from Option<u16> to Option<NonZeroU16> would enable some memory layout optimizations, allowing port to have the same size as u16. Trying this out locally results in a 10% smaller memory footprint for Url (88 bytes -> 80 bytes).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: use NonZeroU32 for query and fragment start DonIsaac/rust-url
1 participant
@DonIsaac