Restart loop if update failed and suspicious binary_name mismatch in log-file

[dragetd]

Describe the bug
A user reported a restart-loop and sent in some interesting logs. The logfiles cannot be attached to this issue because they container information not intended for public use.

I have the log saved next to my trivrost development directory and we can have a look next time we dive into the issues.

This bug serves as a reminder for us to look into it. Once we figured out what happened here, we can close this issue and open more relevant issues or fix the things right away. :)

[JulindM]

The problem with the restart loop is because Windows does not allow having 2 Folders with the same name and, to top it off, it is case insensitive! So for windows, having a folder named TEST and test it considers them the same.

This is the culprit to the problem! The vendorname was in our case company but an old artifact had the vendor Company. This mismatch caused the launcher to keep restarting, because it could not write into the folder company because it was occupied by Company.

[dragetd]

Thank you very much for the input! This could very well be the issue.

Martin, we should go through all code path and check if we have messed up the case sensitivity handling.

[MMulthaupt]

I completely missed this issue. We rushed in a fix here 8107351 which fixed the bug.

@theJuli I believe we wrote somewhere, that Vendor name and Product name should not change after the first release; i.e. I am not sure if above commit would fix your issue as well. You can try with v1.5.0-rc1 which is the first (and latest) release to contain the fix.