Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgk/fetching: do not log.Printf() #243

Open
MMulthaupt opened this issue Apr 15, 2021 · 0 comments
Open

pgk/fetching: do not log.Printf() #243

MMulthaupt opened this issue Apr 15, 2021 · 0 comments

Comments

@MMulthaupt
Copy link
Collaborator

MMulthaupt commented Apr 15, 2021

Go's logging framework is bad: there is no way to differ between log levels, or be able to tell where a log came from. By default we treat logs to the default logger as warnings. However, we just introduced fingerprint logging in pgk/fetching. This specific log line then appears as a warning in the log, when it actually is just info. Potential fixes include:

  • Global package-level logger variable (the usual suspect)
  • Object-level logger variable (kinda bonkers because you can end up having to provide it very often)
  • Some interface that someone made (ugh)
  • Some interface that we made (NIH)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant