New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong formula for calc-target in SAC? #63

Open

BeFranke opened this issue Jul 25, 2024 · 0 comments

BeFranke commented Jul 25, 2024

See https://github.com/seungeunrho/minimalRL/blob/c8efed8481e3cd40e9739cfde220a55522555b57/sac.py#L127C1-L127C54

Shouldn't the formula be target = r + gamma * (1 - done) * (min_q + entropy)?

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment